feat(data ingest): preflight parity — the dry-run's promise becomes a checked contract#150
Merged
saadqbal merged 2 commits intoJul 7, 2026
Conversation
… checked contract backend#828 P3; closes cli#69, cli#71, cli#72, cli#73. Every local check now previews a NAMED data-ingestors validator with matching semantics, so 'preflight passed' means the in-cluster validation passes too — failures land BEFORE the upload, not after. New previews (internal/push/preflight.go, each cites its source rule): - label column exists (LabelColumnValidator: exact, then case-insensitive+trimmed — never stricter than the cluster) (#69) - BOM: tabular rejected pre-upload (the in-cluster stdlib schema probe falsely rejects BOM'd CSVs — data-ingestors#338); image/text BOM accepted+stripped, matching the pandas paths (#71) - every image decoded (header-only, cheap): zero-byte, corrupt, resolution vs target — plus the labels↔images cross-check with the ingestor's _has_extension naming semantics (dotted stems!) (#72) - duplicate headers (stripped, case-SENSITIVE like the probe), zero data rows, --schema columns ⊆ header, CSV encoding gate (check_csv_encoding preview: UTF-8 + no NUL) (#73 + gaps found) - label diversity (LabelDiversityValidator: >=2 classes; NA-sentinel drop + numeric collapse for schema-typed tabular labels; empty string IS a class for image/text) — discovered BY the harness's first run, was in no ticket - object_detection images↔annotations stem pairing (FilePairingValidator preview) FIXES A PRE-EXISTING SHIP-BLOCKER found by the adversarial pass: spec.go swapped target_size to [H,W] on emit (mistaken review note) — but the schema + ImageResolutionValidator compare PIL's (W,H) verbatim, so EVERY non-square dataset failed in-cluster post-upload. Emission is now [W,H]; the parity pair imgc-nonsquare / imgc-nonsquare-swapped pins the orientation end-to-end against the real validator. THE PARITY HARNESS (the durable part): - internal/push/testdata/parity: 23 fixture cases + goldens.json GENERATED from the real Python validators (scripts/gen-validator-goldens.py; scripts/sync-validator-goldens.sh --check for drift, verdict-level) - parity_golden_test.go asserts the PRODUCTION dispatch (push.PreflightDataset — shared by runDataIngest and the test, so the two cannot drift) reaches the manifest's verdict per case, and that committed goldens match the manifest — an ingestor rule change fails the test until consciously reconciled - deliberate divergences (read-/transfer-time failures the ingestor's preflight can't see but the CLI previews) are explicit manifest notes, never silent Verified: 23/23 parity green; full go test green; live dry-runs on a real cluster (missing file, bad label column, single-class, latin-1, non-square 320x200 accept). Adversarial review (2 lenses, high effort): all findings folded incl. the [W,H] bug, value-semantics divergences in diversity/cross-check, the encoding gate, de-masked fixtures, the shared dispatch, and a vacuous kubeconfig test revived with decodable fixtures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
👋 Heads-up — Code review queue is at 38 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This was referenced Jul 7, 2026
CheckLabelDiversity collapsed numeric-looking labels ("1"/"1.0") for
every tabular_classification dataset. The in-cluster LabelDiversityValidator
pins dtype=str for string-family schema types (VARCHAR/CHAR/TEXT/STRING),
so those labels stay distinct — only numeric types get pandas numeric
inference (data-ingestors #252). A user-declared VARCHAR label with
numeric-looking classes was wrongly rejected at preflight.
Derive the drop-NA and collapse-numeric flags from the label's declared
schema type at the dispatch site; keep image/text (untyped) unchanged.
Adds leaf + dispatch tests. This aligns the Go side with the golden
generator, which already types columns as VARCHAR.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
merged commit 8f97a1b
into
reland/145-ingest-guard-and-extension
2 checks passed
saadqbal
added a commit
that referenced
this pull request
Jul 7, 2026
…n handling (#149) * feat(data ingest): destination-table guard (--overwrite) + honest extension handling (#145) Two fixes for the same failure class — the customer uploads their whole dataset and only then learns it was doomed: cli#70 (P4-lite) — table-exists guard: - One cheap read (the data list query) after cluster discovery, BEFORE staging. Existing table without --overwrite → exit 6 (new, documented) with the full remedy; --overwrite replaces it via the exact teardown data delete uses. The check fails OPEN with a visible note (the in-cluster duplicate check still backstops). - Teardown acts on the MATCHED name, not the flag's casing (Linux MySQL + PVC paths are case-sensitive; acting on the flag spelling could silently no-op the DROP/rm and claim success). - --overwrite + --idempotency-key is refused outright: a replayed submit attaches to the PREVIOUS run after the teardown deleted the data — false success + data loss. (Adversarial-review catch.) - Honest partial-failure copy: a half-finished replace names `data delete` as the primary recovery — a plain re-run would pass the DB-backed guard and hit the leftover files after a full upload. - The teardown pod honors --stage-pod-image (air-gapped registries). cli#68 — extension detection/emission: - .webp removed from the accept-set: the ingestor's FileExtension enum + the ingest.v1 schema allow only .jpg/.jpeg/.png for images, and FileTypeValidator RAISES on webp — accepting it locally guaranteed an in-cluster failure after the full upload. (The old comment claiming chart support was itself the cli#68 drift.) - The single shared extension is detected, shown in the summary ("3 files (.png)"), and emitted as spec.file_options.extension so the cluster validates the type that was actually staged — previously it checked its .jpeg convention default and rejected .jpg/.png datasets after upload. - Mixed types fail locally with counts (exit 3); an all-unsupported dataset names what was found vs accepted. Cross-repo traced against data-ingestors (conventions merge, per- category validator factories, DuplicateValidator) and live-verified on a real cluster: PNG detection, guard on an existing table (exit 6), --overwrite dry-run creates nothing, mixed extensions refused, combo flag refusal. go build/vet/test green; new tests cover the guard seam (matched-name contract, fail-open), extension detection, spec emission + schema validation (keypoint top-level fields pinned), and the summary rendering. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(data ingest): preflight parity — the dry-run's promise becomes a checked contract (#150) * feat(data ingest): preflight parity — the dry-run's promise becomes a checked contract backend#828 P3; closes cli#69, cli#71, cli#72, cli#73. Every local check now previews a NAMED data-ingestors validator with matching semantics, so 'preflight passed' means the in-cluster validation passes too — failures land BEFORE the upload, not after. New previews (internal/push/preflight.go, each cites its source rule): - label column exists (LabelColumnValidator: exact, then case-insensitive+trimmed — never stricter than the cluster) (#69) - BOM: tabular rejected pre-upload (the in-cluster stdlib schema probe falsely rejects BOM'd CSVs — data-ingestors#338); image/text BOM accepted+stripped, matching the pandas paths (#71) - every image decoded (header-only, cheap): zero-byte, corrupt, resolution vs target — plus the labels↔images cross-check with the ingestor's _has_extension naming semantics (dotted stems!) (#72) - duplicate headers (stripped, case-SENSITIVE like the probe), zero data rows, --schema columns ⊆ header, CSV encoding gate (check_csv_encoding preview: UTF-8 + no NUL) (#73 + gaps found) - label diversity (LabelDiversityValidator: >=2 classes; NA-sentinel drop + numeric collapse for schema-typed tabular labels; empty string IS a class for image/text) — discovered BY the harness's first run, was in no ticket - object_detection images↔annotations stem pairing (FilePairingValidator preview) FIXES A PRE-EXISTING SHIP-BLOCKER found by the adversarial pass: spec.go swapped target_size to [H,W] on emit (mistaken review note) — but the schema + ImageResolutionValidator compare PIL's (W,H) verbatim, so EVERY non-square dataset failed in-cluster post-upload. Emission is now [W,H]; the parity pair imgc-nonsquare / imgc-nonsquare-swapped pins the orientation end-to-end against the real validator. THE PARITY HARNESS (the durable part): - internal/push/testdata/parity: 23 fixture cases + goldens.json GENERATED from the real Python validators (scripts/gen-validator-goldens.py; scripts/sync-validator-goldens.sh --check for drift, verdict-level) - parity_golden_test.go asserts the PRODUCTION dispatch (push.PreflightDataset — shared by runDataIngest and the test, so the two cannot drift) reaches the manifest's verdict per case, and that committed goldens match the manifest — an ingestor rule change fails the test until consciously reconciled - deliberate divergences (read-/transfer-time failures the ingestor's preflight can't see but the CLI previews) are explicit manifest notes, never silent Verified: 23/23 parity green; full go test green; live dry-runs on a real cluster (missing file, bad label column, single-class, latin-1, non-square 320x200 accept). Adversarial review (2 lenses, high effort): all findings folded incl. the [W,H] bug, value-semantics divergences in diversity/cross-check, the encoding gate, de-masked fixtures, the shared dispatch, and a vacuous kubeconfig test revived with decodable fixtures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(preflight): label diversity respects the label's SQL type (#152) CheckLabelDiversity collapsed numeric-looking labels ("1"/"1.0") for every tabular_classification dataset. The in-cluster LabelDiversityValidator pins dtype=str for string-family schema types (VARCHAR/CHAR/TEXT/STRING), so those labels stay distinct — only numeric types get pandas numeric inference (data-ingestors #252). A user-declared VARCHAR label with numeric-looking classes was wrongly rejected at preflight. Derive the drop-NA and collapse-numeric flags from the label's declared schema type at the dispatch site; keep image/text (untyped) unchanged. Adds leaf + dispatch tests. This aligns the Go side with the golden generator, which already types columns as VARCHAR. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Asad Iqbal (Saadi) <asad.dsoft@gmail.com> * fix(preflight): check deferred file Close (errcheck) preflight.go used bare `defer f.Close()`, which the required Lint job's `errcheck ./...` rejects on develop. Match the repo convention used in detect.go / tabular.go / stream.go: `defer func() { _ = f.Close() }()`. These are read-only opens for validation, so dropping the close error is intentional. Slipped through earlier because the stacked merges never hit the full Lint-on-develop gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Asad Iqbal (Saadi) <asad.dsoft@gmail.com>
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note — re-land of #147
#147 was merged at 08:50, but into
feat/ingest-guard-and-extension— a stacked base whose own content never reacheddevelop(#145 had been merged into #142's branch AFTER #142 was already on develop — see #149). Net: #145 and #147 both show merged while develop has neither.This PR is #147's commit rebased onto #149 (the #145 re-land). Stacked on #149 → develop; GitHub retargets it automatically when #149 merges. Content is what was already merged in #147 (plus the
31e8a1ffixes that are already on develop via #142's squash). Full test suite green on the rebased tree.Merge order: #149 first, then this. Both are content you've effectively already reviewed.
Summary
P3 of backend#828 — closes cli#69, cli#71, cli#72, cli#73 (+1 rule no ticket had). Stacked on #145 → #142; retargets down the stack as they merge.
Every local check now previews a named data-ingestors validator with matching semantics, so preflight passed ⇒ in-cluster validation passes — failures land before the upload, not after. And the claim isn't taken on faith: a parity harness pins it against the real Python validators.
The previews (
internal/push/preflight.go, each cites its source rule)_has_extensionnaming rules (dotted stems likephoto.2024resolve, not reject)--schemacolumns ⊆ header, and the CSV encoding gate (UTF-8 + no NUL — the first thing the cluster checks)🚨 Fixes a pre-existing ship-blocker
The adversarial pass empirically proved
spec.go's[H,W]swap ontarget_sizeemission wrong (the schema + ImageResolutionValidator compare PIL's(W,H)verbatim) — every non-square dataset failed in-cluster post-upload, 100%. Emission is now[W,H], pinned end-to-end by theimgc-nonsquare/imgc-nonsquare-swappedparity pair (8×4 images:[8,4]passes both sides,[4,8]rejects both sides — verified against the real validator).The parity harness (the durable part)
goldens.jsongenerated from the real Python validators (scripts/gen-validator-goldens.py,sync-validator-goldens.sh --checkfor verdict-level drift)parity_golden_test.gorunspush.PreflightDataset— the production dispatch, shared withrunDataIngest, so test and reality cannot drift (deleting/rewiring a check fails parity)imgc-dup-headerwhere the real validators accept and the rejection is read-time-onlyVerification
23/23 parity green · full
go test ./...green · live dry-runs on a real cluster (missing file / bad label column / single-class / Latin-1 all caught pre-upload; a 320×200 non-square dataset — previously doomed — sails through) · adversarial review (2 lenses): all findings folded, including de-masked fixtures and a vacuous kubeconfig test revived with decodable fixtures.Refs: backend#828 (P3) · backend#879 · data-ingestors#338.
🤖 Generated with Claude Code