Conversation
…evelop fix(installer): two R8 curl|bash install P0s — stamper guard-clobber + provision --name (→ v1.8.2)
aptracebloc
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #289 (already on develop) to
mainto cut v1.8.2. Delta vs main is exactly #289's 5 files — nothing else is ahead on develop.Two P0s that broke the R8
curl | bashinstall end to end (both found by running the installer, which v1.8.1 never did):sign-installer-manifestreplaced__TRACEBLOC_RELEASE_REF__globally, rewriting the fail-closed guard to== "v1.8.1"so the stamped installer errored "wasn't stamped" for everyone. Now stamps only/^DEFAULT_REF=/, asserts the guard sentinel survives, and the self-test runs the stamped installer.--name—client create's output is redirected to the log so it can't prompt and requires--name; every browser-auth install failed at Step 3. Now supplies name(+location) via env →/dev/ttyprompt → fail closed.Chart bumped 1.8.1 → 1.8.2;
manifest.sha256regenerated for the provision.sh change. Verified locally (stamped installer clears the guard; provision.bats 12/12; shellcheck clean). FR gate bypassed viaskip-fr-gate(hotfix).On merge I cut v1.8.2 and verify by running
curl | bashthrough provisioning end to end.🤖 Generated with Claude Code
Note
Medium Risk
Touches the release supply-chain stamping path and interactive provisioning for browser-auth installs; changes are targeted with regression tests, but a bad release would still block all curl installs until fixed.
Overview
v1.8.2 fixes two P0 regressions that broke
curl | bashinstalls after v1.8.1.The release workflow’s installer stamper now replaces
__TRACEBLOC_RELEASE_REF__only on theDEFAULT_REF=line, so the fail-closed guard that compares"$REF"to the placeholder is not rewritten to the release tag (which caused every stamped installer to report “wasn’t stamped”). Post-stamp checks assertDEFAULT_REFmatches the tag and the guard sentinel is intact; the self-test runs the stampedinstall.shand fails if that guard still trips, in addition to the existing mutable-BRANCHnegative case.provision.shcollects machine name (and optional location) viaTRACEBLOC_CLIENT_*env, interactive prompts on/dev/ttywhen available, or a clear error when neither is possible—then passes--name/--locationintotracebloc client create, since CLI output is redirected to the log and cannot prompt. Chart version is bumped 1.8.1 → 1.8.2;manifest.sha256is updated for the provision change; provision.bats adds coverage for argv passthrough and the no-name/non-TTY fatal path.Reviewed by Cursor Bugbot for commit 5a03236. Bugbot is set up for automated code reviews on this repo. Configure here.