fix(installer): make the training size configurable at install (TRACEBLOC_TRAINING_RESOURCES)#308
Open
LukasWodka wants to merge 1 commit into
Open
fix(installer): make the training size configurable at install (TRACEBLOC_TRAINING_RESOURCES)#308LukasWodka wants to merge 1 commit into
LukasWodka wants to merge 1 commit into
Conversation
The generated values hardcoded RESOURCE_LIMITS/REQUESTS to
cpu=2,memory=8Gi with no way to override — the 'default configuration'
was frozen. One env knob now sets both (requests == limits, Guaranteed
QoS, matching client-runtime's lockstep default):
TRACEBLOC_TRAINING_RESOURCES="cpu=4,memory=16Gi" bash <(curl … i.sh)
Groundwork for the `tracebloc resources` command (design approved by
Lukas 2026-07-06): that command becomes the friendly layer over the
same chart values; this is the install-time escape hatch.
+2 bats tests (override lands in generated values; default unchanged).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generated values hardcoded
RESOURCE_LIMITS/REQUESTS: cpu=2,memory=8Gi— the install-time default was frozen with no override. One env knob now sets both (requests == limits, Guaranteed QoS, matching client-runtime's deliberate lockstep):Documented in the installer header + a YAML comment in the generated values. Groundwork for the
tracebloc resourcescommand (design approved; ticket in tracebloc/cli) — that becomes the friendly runtime layer over the same chart values.Testing
+2 bats tests (override lands in generated values / default unchanged); full install-client-helm suite 48/48 locally (Linux CI authoritative). manifest.sha256 regenerated.
🤖 Generated with Claude Code