INF-1484/fix: Lower requires-python to 3.10 to unbreak consumers#23
Merged
Conversation
The action pip-installs itself with the consumer-supplied python-version input, and 12 repos pin 3.10, so requiring >=3.11 broke their pre-commit checks. The modules are 3.10 compatible (19 tests pass under 3.10).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum Python version requirement in pyproject.toml from >=3.11 to >=3.10 to accommodate consumers who pin to Python 3.10. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
INF-1484 (#21) added
pyproject.tomlwithrequires-python = ">=3.11". The action pip-installs itself with the consumer-suppliedpython-versioninput, and 12 repos pin"3.10"in their style workflow (admin-portal, airflow-integration, buyer-portal, checkout-page, e2e-tests, mock-proxy, portals, repay, shop, two-logger, woocommerce-plugin, woocommerce-abn-plugin), so every pre-commit check in those repos now fails with:First seen on e2e-tests PR #413.
Changes
requires-pythonto">=3.10"with a comment explaining the coupling to consumer pinsScope / Non-goals
python-versioninput (a separate interpreter for the action scripts would be the structural fix, but this unbreaks CI now)Validation
uv run --python 3.10 --with pytest --with . pytest -q→19 passedpy_compile)Ticket
🤖 Generated with Claude Code