Repository navigation
docs(detection): correct AgentDojo security field meaning in README - #210
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
The README said AgentDojo's `security` field is False when the attack succeeded. AgentDojo injection tasks return security=True when the injection goal is met, and main_benchmark.py copies that value into `is_malicious` (True = attack succeeded), as the line above states. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
README line now says True = attack succeeded (copied to is_malicious).
Why?
Detection/README.md:233 says
security: "(False = attack succeeded)", contradicting the line above (is_malicious: True if attack succeeded) and the code: main_benchmark.py_convert_agentdojo_resultssetsis_malicious = security, and AgentDojo injection tasks'security()returns True when the injection goal is achieved (e.g. benchmark/agentdojo/benchmarks/agentdojo/default_suites/v1/slack/injection_tasks.py InjectionTask1 returns True if the phishing link reached Alice).How did you test it?
Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.
AI assistance: Claude Code (model Claude Opus 5.5) found this bug, wrote the fix and test, and drafted this description; submitted by @rudycelekli.
🤖 Generated with Claude Code