Repository navigation
fix(sensor): record the message of a failed Copilot tool's error - #214
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Copilot's session events record a failed tool's error as an object,
{"message": ..., "code": ...}. The parser serialized that object, so
ToolUsage.error held a JSON blob such as
'{"message": "The user rejected this tool call.", "code": "denied"}'.
It now uses the message; plain string errors are handled as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
New
_normalize_tool_errorreturns the (truncated)messagewhen the error is an object with a non-empty string message; anything else goes through the old path, so the existing string-error test still passes.Why?
Copilot's schema defines tool.execution_complete
erroras ToolExecutionCompleteError{"message": str, "code"?: str}(github/copilot-sdk session_events.py). CopilotParser passes it to_normalize_tool_result(Sensor/adr_sensor/parsers/copilot_parser.py:302), which only knows result objects (detailedContent/content) and falls back to json.dumps, so a rejected tool gets error'{"message": "The user rejected this tool call.", "code": "denied"}'.How did you test it?
TestCopilotParser::test_tool_failure_uses_message_of_error_object. main parser: FAILED ('{"message": ...e": "denied"}' == 'The user rej...is tool call.'); branch: passed.pytest tests/ -q(py3.14) 609 passed; Python 3.9.6 parser test files 245 passed.codeis dropped (still not exported elsewhere).Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.