Repository navigation
fix(sensor): keep Gemini CLI history patches out of session metadata - #216
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Gemini CLI journals now append {"$patch": {...}} records when it syncs
history (masked tool output, removed or reordered messages). The parser
only knew $rewindTo and $set, so a patch was merged into session_metadata
under a "$patch" key, each one replacing the last. Patches are now kept
in journal_controls like rewinds, and recorded activity is left as-is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Treat
$patchrecords like$rewindTo: append them to journal_controls and do not apply them, consistent with the module's stated policy of retaining recorded activity across rewinds (masking/removing model context does not undo actions). Tool results still come from full message upserts (recordToolCalls -> pushMessage), which are unchanged.Why?
Gemini-cli (google-gemini/gemini-cli#29568, merged 2026-10-01, packages/core/src/services/chatRecordingTypes.ts
MessagePatchRecord, chatRecordingService.ts:1587appendRecord({ $patch: patchPayload })) now appends{"$patch": {updates, removeIds, orderIds}}records when it syncs history (tool-output masking, removed/reordered turns). GeminiParser.parse_file (Sensor/adr_sensor/parsers/gemini_parser.py:143-156) only special-cases$rewindToand$set; any other record without "id" is treated as a metadata update, so the whole patch lands insession_context.session_metadata["$patch"], each patch overwriting the previous one, and it is not listed injournal_controls.How did you test it?
tests/test_gemini_parser.py::test_history_patch_is_a_journal_control_not_session_metadata. main: FAILED ('$patch' not in {...session_metadata...}); branch: passed (patch in journal_controls, original tool result and both messages kept).pytest tests/ -q(py3.14) 609 passed; ruff clean; Python 3.9.6 parser test files 245 passed.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.
AI assistance: Claude Code (model Claude Opus 5.5) found this bug, wrote the fix and test, and drafted this description; submitted by @rudycelekli.
🤖 Generated with Claude Code