Repository navigation
fix(runway): reject merged GitHub pulls listed after unmerged ones - #836
Merged
behinddwalls merged 9 commits intoOct 20, 2026
Merged
Conversation
DivyanshGarg380
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 12, 2026 12:48
Contributor
Author
|
Hi @behinddwalls, just following up on this PR. Would appreciate a review when you get a chance. |
behinddwalls
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
validateStepIsGitHubStackcontains an ineffective ordering check. It checks the prefix of pull requests returned byunmergedPulls, rather than validating the suffix containing unmerged pull requests.Consequently, a merged pull request listed after an unmerged pull request can bypass validation and reach the GitHub stack lookup path.
What?
unmergedPullsand reject any already-merged pull request found after the first unmerged pull request.merger.ErrInvalidRequestfor invalid pull request ordering.Test Plan
go test ./runway/extension/merger/github -run TestValidateStepIsGitHubStack_MergedMustPrecedeUnmerged -count=1go test ./runway/extension/merger/github -count=1python .\tool\bazel --output_user_root=C:\bazel test //runway/extension/merger/github:allAll tests passed.
Issue
Closes #835