Skip to content

fix(web): simplify Stovepipe results and separate repository status - #904

Merged
mnoah1 merged 2 commits into
mainfrom
mnoah1/stovepipe-result-layout
Oct 21, 2026
Merged

mnoah1 merged 2 commits into
mainfrom
mnoah1/stovepipe-result-layout

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Why?

Project result percentages add noise, and the repository result is mixed into the project table.

What?

Show Green or Breakage without percentages, keeping No result recorded for missing data. Move Repository result into Request status above History, leaving only projects in the Project results table. Preserve successful results after a failed refresh.

Test Plan

  • Stovepipe library: 40 tests passed, including result labels, repository placement, missing sections, and refresh behavior.
  • Full web check passed: 31 test targets, including React 18 package rendering and hydration, lint, typechecks, and deployable image builds. Repository lint, dependency, and build-file checks passed.
  • Real-stack E2E: Stovepipe (5 tests) and SubmitQueue (5 tests) passed locally, including server-rendered styling, project cursors, refresh, missing results, and accessibility checks. E2E typecheck also passed.
  • Validation command: ./tool/bazel test //web/test/e2e/stovepipe:web_test //web/test/e2e/submitqueue:web_test //web/test/e2e/stovepipe:typecheck_typecheck_test --test_output=errors.
  • PR CI: all 17 checks passed.

@mnoah1
mnoah1 marked this pull request as ready for review October 21, 2026 14:42
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 21, 2026 14:42
@mnoah1
mnoah1 added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 21, 2026
Show Green or Breakage without percentages and preserve missing results.
Move the repository result above history, outside the project results table.
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-result-layout branch from 5027f86 to 2f61cd9 Compare October 21, 2026 15:30
@mnoah1
mnoah1 added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit dc1db41 Oct 21, 2026
20 checks passed
@mnoah1
mnoah1 deleted the mnoah1/stovepipe-result-layout branch October 21, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants