Repository navigation
fix(showcase): restore native HTML demo on GitHub Pages - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the broken Native HTML demo.
The showcase is built against OpenUI5 1.154.0, but its production CDN bootstrap and dist-preview configuration still used 1.148.2. Since
sap.htmlwas introduced in 1.154.0, the deployed app failed to load the library and could not construct the sample view.sap.htmlin the dist-preview framework libraries.sap.htmldeclarations.Validation
pnpm --filter @ui5-community/jsx-runtime-showcase buildpnpm --filter @ui5-community/jsx-runtime-showcase test— type-check, lint, framework guard and all 3 OPA5 journeys pass.sap.html.The public demo will receive the fix through the existing GitHub Pages deployment after merge.