Spectro#124
Conversation
…troller, Laser & Diode GPIO Controllers
Hwi upgrades
IshanDutta11
left a comment
IshanDutta11
left a comment
There was a problem hiding this comment.
I would like to continue reviewing this but there are major build problems:
`
CMake Error at CMakeLists.txt:28 (find_package):
By not providing "Findraman_msgs.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"raman_msgs", but CMake did not find one.
Could not find a package configuration file provided by "raman_msgs" with
any of the following names:
raman_msgsConfig.cmake
raman_msgs-config.cmake
Add the installation prefix of "raman_msgs" to CMAKE_PREFIX_PATH or set
"raman_msgs_DIR" to a directory containing one of the above files. If
"raman_msgs" provides a separate development package or SDK, be sure it has
been installed.
`
This is most likely happening because there is another raman_msgs package within the msgs package. Fix this and also describe how to use this to me. It will make it easier to test.
| <robot xmlns:xacro="http://www.ros.org/wiki/xacro"> | ||
|
|
||
| <xacro:macro name="laser_ros2_control" params="name can_interface:=can0"> | ||
| <xacro:macro name="laser_ros2_control" params="name can_interface:=can0 port_id:=0"> |
There was a problem hiding this comment.
Why not just use node_id by a per HWI parameter basis?
There was a problem hiding this comment.
Why is there a whole package for these messages? Can't you just put it in msgs?
| </hardware> | ||
|
|
||
| <gpio name="${name}"> | ||
| <command_interface name="capture_binary"/> |
There was a problem hiding this comment.
Can you add a param called node_id? I know we only have 1 spectrometer but it will keep everything consistent.
| @@ -63,8 +72,10 @@ class LaserHardwareInterface : public hardware_interface::SystemInterface | |||
| }; | |||
|
|
|||
| void onCanMessage(const CANLib::CanFrame & frame); | |||
There was a problem hiding this comment.
Nitpicking but can we make this snake case?
There was a problem hiding this comment.
What is this for? I don't see it being used anywhere.
There was a problem hiding this comment.
Thanks, I needed to do this lol.
2 participants
No description provided.