[pi0x]

Adds upm lockfile (upm.lock) to the lockfiles used by resolveLockfile and findWorkspaceDir.

Follow-up to unjs/nypm#269.

• Add upm.lock to lockfile list
• Document it in README
• Add upm fixture and resolveLockfile test

🤖 Generated with AI assistant

Summary by CodeRabbit

• New Features

  • Added support for detecting upm.lock files during lockfile resolution and workspace detection.
  • Documented upm.lock as a recognized lockfile.

• Tests

  • Added coverage confirming that projects using upm correctly resolve their upm.lock file.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 9fd55557-66af-46d1-aaa8-d0dd857fe80f

📥 Commits

Reviewing files that changed from the base of the PR and between d573518 and 830255e.

⛔ Files ignored due to path filters: 1

• test/fixture/upm/upm.lock is excluded by !**/*.lock

📒 Files selected for processing: 4

• README.md
• src/packagejson/utils.ts
• test/fixture/upm/package.json
• test/index.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The lockfile resolver now recognizes upm.lock. The README lists the filename, and a fixture-backed test verifies resolution under the upm directory.

Changes: UPM lockfile recognition

Layer / File(s)	Summary
Recognize and verify upm.lock src/packagejson/utils.ts, test/fixture/upm/package.json, test/index.test.ts, README.md	The recognized lockfile names include upm.lock. A fixture and test verify that resolveLockfile returns ./upm/upm.lock. The README lists the filename.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: igalklebanov

Merge Risk: ⚪ Minimal · up to 83025

This change is low risk and ready to merge.

Architecture Summary

Architecture risk: 🔵 Low · up to 83025

The change affects 3 systems.

Changed systems: src, test, README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — src (service) was modified; 1 changed file maps to changed impact.
• observed — test (service) was modified; 2 changed files map to changed impact.
• observed — README.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in README.md: Updated resolveLockfile documentation to list upm.lock as an additional recognized lockfile.
• observed — Modified behavior in src/packagejson/utils.ts: The recognized lockfile list now includes upm.lock, so lockfile lookup and related workspace detection can match this filename.
• observed — Modified behavior in test/fixture/upm/package.json: Added package metadata identifying the private fixture-upm package and requiring upm@1.3.1.
• observed — Modified behavior in test/index.test.ts: Added coverage confirming resolveLockfile returns ./upm/upm.lock for the upm fixture directory.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: adding detection for the upm.lock lockfile.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}