Repository navigation
ci(lsc): make the lsc step advisory where it disagrees with the spec format - #6
Merged
Merged
Conversation
…format lsc 0.2.0 reports 1 error (R04, H1 naming) and 7 warnings (R05, custom sections) on SPEC-0001, while the repo spec-check passes. Under the estate rule of 2026-10-18 the repo's own spec-check is the gate where the two disagree, so the stub now turns lsc findings into a warning instead of failing the job once lsc reaches the runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: writes are blocked for lane seats right now (operator notice, 2026-10-18 14:44Z). The saga lane tracks this change locally and will backfill the ticket under the dgr umbrella once writes are restored. Spec touched: none; this is a CI-only change.
Why
lsc 0.2.0now exists and disagrees with this repo's spec format. On SPEC-0001 it reports 1 error (R04: the H1 must equal the file stem) and 7 warnings (R05: custom H2 sections), while the repo's own structural spec-check passes. The lsc step from PR 5 runslsc check specs/as a hard step wheneverlscis on the runner. So as soon as lsc reaches theci-rustrunners, every PR here would go red.The estate rule of 2026-10-18 says that where lsc and a repo's spec-check disagree, the repo's own spec-check is the gate.
What
The lsc step becomes advisory. If
lscis present it still runs, and any findings appear as a::warning::. The structural spec-check step is unchanged and stays the gate. Nothing else changes.Evidence
actionlintpassed, ignoring only the customci-rustrunner label.lsc 0.2.0on PATH against a full export oforigin/main: the new step exits 0 and emits the warning, and the old step exits 1. That control shows the old step really fails today.