Repository navigation
deps: bump axios to 1.20.0 and remove stale package-lock.json - #141
Open
rcooney-sh wants to merge 1 commit into
Open
rcooney-sh wants to merge 1 commit into
rcooney-sh wants to merge 1 commit into
Conversation
Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears Aikido AIKIDO-2026-10823 (axios, patched in 1.16.1) for setup-docker-builder, tracked in Linear SEC-690. Aikido flagged axios 1.15.0 in
pnpm-lock.yamland 1.13.4 inpackage-lock.json.axios is a direct dependency (used in
src/reporter.tsandsrc/buildkit-installer.ts), so it's bumped directly instead of through an override. 1.20.0 is the latest 1.x and covers the rest of the axios advisories in the vulnagent batch (the ticket asks for >=1.18.0):The lockfile moves axios 1.15.0 -> 1.20.0. It also pulls in axios's new transitive deps: follow-redirects 1.15.11 -> 1.16.1, form-data 4.0.5 -> 4.0.6, hasown 2.0.4, https-proxy-agent 5.0.1, and agent-base 6.0.2. axios-retry 4.5.0 is unchanged; its peer range
axios: 0.x || 1.xstill matches.Why
package-lock.jsonis removed: the repo uses pnpm.engines.pnpmis 10.33.0, there's apnpm-workspace.yaml, every workflow (build, lint, verify-build, release) runspnpm install, and the lefthook pre-commit hook only diffspnpm-lock.yaml.package-lock.jsonwas last touched in #91 and has drifted. It still pins@buf/blacksmith_vm-agent.bufbuild_es1.9.0,@connectrpc/connect^1.6.1, and aconnectrpc_espackage thatpackage.jsonno longer declares. Nothing reads it except scanners, so it's deleted instead of being regenerated as a second source of truth.dist/ is intentionally not rebuilt here.
dist/index.jsstill bundles axios 1.15.0, so verify-build will fail until a maintainer rebuilds and commits dist on this branch:After merge, the running artifact only changes once a release is cut: run the Release workflow from
mainwith versionv1.14.0and update-major checked, which movesv1. v2 lives onrelease/v2and has its own backport PR.Promotion risk: Low. This is a minor-version bump of one HTTP client (axios 1.15.0 -> 1.20.0, same 1.x API) used in two non-critical call sites. The only behavior change Proof saw is how HTTPS goes through a proxy, and nobody has tested that on a real proxied runner.
dist/is rebuilt; this diff alone changes no shipped code.@mainconsumers get it at merge,@v1consumers whenv1.14.0moves the tag. After that,dist/index.jsbundles axios 1.20.0. axios is used for Blacksmith API/metrics reporting insrc/reporter.ts(failures there only logcore.warning) and the BuildKit tarball download from github.com insrc/buildkit-installer.ts. The download only runs when a job setsbuildkit-versionto a version that isn't preinstalled. The v1.14.0 release also ships the unreleased discard the sticky disk's resolv-host.conf before buildkitd starts #140 (resolv-host.conf), which is not part of this risk call.HTTPS_PROXYset, axios now tunnels HTTPS throughCONNECTvia the newhttps-proxy-agent@5.0.1dependency. 1.15.0 sent absolute-URLGETs to the proxy; the change is the 1.16.1 "proxy cleartext leak" fix. A proxy that refusesCONNECTwould make the BuildKit download fail and the setup step error withInstalling BuildKit ...followed by an axios error. Reporting calls would only emit warnings.maxContentLengthis enforced on streams, malformedhttp:/https:URLs are rejected, and NO_PROXY matching changed. None of these touch the fixed URLs this action uses.0.x || 1.xstill matches.test-action.yml,test-buildkit-version.yml) ranpnpm install && pnpm run buildand thenuses: ./on real Blacksmith runners, all green. That is a full ncc/TypeScript compile with axios 1.20.0, plus a real builder setup that includes the custom-BuildKit download path.reporter.tsandbuildkit-installer.tson 1.15.0 vs 1.20.0: 503 retries, give-up after 5 retries, and the GitHub download behaved identically. Through a permissive test proxy the download succeeded on both versions; the only difference was CONNECT vs plain forwarding.dist/(not rebuilt yet, soverify-buildfails).@v1once thev1tag moves. That includes customers whose workflows Blacksmith's migration tool rewrote to@v1, and FastActions/fa image builds.@mainconsumers (fadocker_cron.yaml,test-buildx-caching.yml) pick it up at merge. SHA pins (fabuild-push-heimdall.yaml, kubernetes, dns) are unaffected until bumped.v1tov1.13.0(git tag -fa v1 v1.13.0^{} && git push --force origin v1). No data or state is involved.Failed to report ...warnings in setup-docker-builder runs, especially jobs that setbuildkit-versionorHTTPS_PROXY.Retries, give-up after 5 retries, and the BuildKit download from GitHub behave identically on 1.15.0 and 1.20.0
Merge-base
This PR
a3ef3d6cAlso checked · 3 more claims, all matched observations
Proof on
a3ef3d6cNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled. (Staging)