Repository navigation
deps: bump axios to 1.20.0 and remove stale package-lock.json (release/v2) - #142
rcooney-sh wants to merge 1 commit into
Conversation
…e/v2) Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 53d7547. Configure here.
| "@docker/actions-toolkit": "0.37.1", | ||
| "@iarna/toml": "^2.2.5", | ||
| "axios": "^1.7.2", | ||
| "axios": "^1.20.0", |
There was a problem hiding this comment.
Action bundle omits axios security fix
High Severity
The axios bump does not reach action consumers because action.yml runs dist/index.js, which still embeds axios 1.15.0 and remains vulnerable to AIKIDO-2026-10823. verify-build does not run on this branch, and the action tests rebuild dist locally, so a merge without a committed rebuild leaves v2 users on the unpatched bundle.
Reviewed by Cursor Bugbot for commit 53d7547. Configure here.
There was a problem hiding this comment.
Valid, but dist/ can't be rebuilt without BUF_TOKEN for the private @buf registry. A maintainer must run the rebuild steps in the PR description before merge.


Backport to
release/v2of the axios fix for Aikido AIKIDO-2026-10823, tracked in Linear SEC-690. Thev2tag (v2.2.0) and the@release/v2branch ref are cut from this branch, so the main-branch fix alone doesn't reach v2 consumers.The change is the same as the main PR: axios
^1.7.2->^1.20.0(lockfile 1.15.0 -> 1.20.0, with follow-redirects 1.16.1, form-data 4.0.6, hasown 2.0.4, https-proxy-agent 5.0.1, and agent-base 6.0.2). It also removes the stale, unusedpackage-lock.json, which still pins axios 1.13.4. This branch installs with pnpm only.dist/ is intentionally not rebuilt here.
dist/index.jsstill bundles axios 1.15.0, so a maintainer must rebuild and commit it on this branch before merge. verify-build only runs on PRs to main/master, so CI won't catch a missing rebuild here:After merge, run the Release workflow from
release/v2with versionv2.2.1and update-major checked, which movesv2.Promotion risk: Low. This is a minor-version bump of one HTTP client (axios 1.15.0 -> 1.20.0, same 1.x API) used in two non-critical call sites. The only behavior change Proof saw is how HTTPS goes through a proxy, and nobody has tested that on a real proxied runner.
dist/is rebuilt; this diff alone changes no shipped code.@release/v2consumers get it at merge,@v2consumers whenv2.2.1moves the tag. After that,dist/index.jsbundles axios 1.20.0. axios is used for Blacksmith API/metrics reporting insrc/reporter.ts(failures there only logcore.warning) and the BuildKit tarball download from github.com insrc/buildkit-installer.ts. The download only runs when a job setsbuildkit-versionto a version that isn't preinstalled.HTTPS_PROXYset, axios now tunnels HTTPS throughCONNECTvia the newhttps-proxy-agent@5.0.1dependency. 1.15.0 sent absolute-URLGETs to the proxy; the change is the 1.16.1 "proxy cleartext leak" fix. A proxy that refusesCONNECTwould make the BuildKit download fail and the setup step error withInstalling BuildKit ...followed by an axios error. Reporting calls would only emit warnings.maxContentLengthis enforced on streams, malformedhttp:/https:URLs are rejected, and NO_PROXY matching changed. None of these touch the fixed URLs this action uses.0.x || 1.xstill matches.test-action.ymlon this branch) ranpnpm install && pnpm run buildand thenuses: ./on real Blacksmith runners, all green. That is a full ncc/TypeScript compile with axios 1.20.0, plus a real builder setup. This branch has no custom-BuildKit-version CI job, so the download path was covered only by Proof.reporter.tsandbuildkit-installer.tson 1.15.0 vs 1.20.0: 503 retries, give-up after 5 retries, and the GitHub download behaved identically. Through a permissive test proxy the download succeeded on both versions; the only difference was CONNECT vs plain forwarding.dist/. It isn't rebuilt yet, andverify-builddoesn't run onrelease/v2, so nothing in CI catches a missing rebuild.@v2once the tag moves: customers following the README/docs default, webbuild_backend_docker.yml/build-and-push-ecr.yml, docker-build-lab and se-demo.@release/v2consumers (webcodesmith-deploy.yml,codesmith-bench.yml,codesmith-snapshot.yml,smoke-pr.yml) pick it up the moment this merges, before any tag. So merge only with the rebuiltdist/committed.v2tov2.2.0(git tag -fa v2 v2.2.0^{} && git push --force origin v2). For@release/v2consumers, revert the merge commit onrelease/v2. No data or state is involved.Failed to report ...warnings in setup-docker-builder runs, especially jobs that setbuildkit-versionorHTTPS_PROXY.Need help on this PR? Tag
@codesmith-botwith what you need.The frozen install now loads axios 1.20.0 with every listed transitive version, and package-lock.json is gone. The private @buf package was left out because no BUF_TOKEN is available.
53d75473Also checked · 2 more claims, all matched observations
Proof on
53d75473Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled. (Staging)