Repository navigation
Conversation
Images in a reply could only be opened or have their path copied, so getting the picture itself into another app meant a detour through the file manager. Generated images and Markdown images now offer Copy image and Download image on right-click; the generated-image viewer also has a copy button and Cmd/Ctrl+C. Copy writes PNG to the clipboard (JPEG, JPG and WebP are re-encoded). Download names come from the URL path without its query or fragment; local paths keep their file name verbatim. Refs vastsa#1917, supersedes vastsa#1918.
muzimu217
reviewed
Oct 28, 2026
muzimu217
left a comment
muzimu217
left a comment
Contributor
There was a problem hiding this comment.
This is the same change I reviewed as #1918, resubmitted as feat per the maintainer's call, and the two points from that review are both in: SUPPORTED_IMAGE_DATA_URL now accepts jpe?g with a comment explaining that sources emit image/jpg often enough to matter, and downloadMarkdownImage strips [?#] before taking the last path segment, with a test for the alias.
Single commit, rebased onto current main, and the permission story is unchanged from #1918: navigator.clipboard.write works because installLiveMicrophonePermissionHandlers grants every non-media permission on session.defaultSession (microphone-permissions.ts:50-58), which is why no IPC change is needed. Nothing new to object to.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1917. 接替 #1918：维护者在 #1918 中判定这是新增能力，应以 feat 提交，因此改为 feat 重新提交。代码与 #1918 最终版本相同（含 review 修复：
image/jpg兼容、URL 下载名去掉?/#），已合并到最新 main 后整理为单个提交。功能
<dialog>，菜单 portal 到 dialog 内，复制结果用内联状态提示（toast 会被顶层遮挡）。验证
pnpm build:js、desktop typecheck、pnpm lint、architecture check、git diff --check通过。image-clipboard、image-download-name、generated-image-context-menu，并更新chat-file-open-with-menu的契约断言。