Replace params: Any in stream/generate with generalized types#150
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
msullivan
approved these changes
May 22, 2026
Contributor
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
This seems more or less reasonable in terms of API surface but I do worry about keeping it up to date?
Though AI makes that a lot easier.
I wonder if there is a table driven approach we could do, though?
Using `params: Any` for the typing of inference parameters is not great, because discoverability and validation. Even though the variability in upstream provider configuration shapes is great, the overlap in common functionality is big enough to warrant ascribing it in common types and concepts. In addition to common parameters, add a provider-specific options section as well as generic `extra_headers`/`extra_query`/`extra_body` escape hatch to drop to untyped underlying API level.
elprans
force-pushed
the
elprans/typify-inference-params
branch
from
a516af0 to
824efe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
params: Anyfor the typing of inference parameters is not great,because discoverability and validation. Even though the variability in
upstream provider configuration shapes is great, the overlap in
common functionality is big enough to warrant ascribing it in common
types and concepts.
In addition to common parameters, add a provider-specific options
section as well as generic
extra_headers/extra_query/extra_bodyescape hatch to drop to untyped underlying API level.