Repository navigation
Fix /deploy uncommitted-changes warning and production match - #324
Merged
Merged
Conversation
…atch - vercel uploads the local working tree, so uncommitted and untracked files ship; the preflight warning said the opposite. - Match prod/production as whole words so arguments like "product" do not trigger the production gate. - Note that vercel logs shows request and runtime logs, not build output, next to the existing vercel inspect --logs failure step.
The CLI collects files with its built-in ignore list plus .vercelignore (or .nowignore). It never reads .gitignore rules, so gitignored files that are not on the built-in list or in .vercelignore ship too.
molebox
force-pushed
the
fix/deploy-command-build-logs
branch
from
October 19, 2026 11:38
716cab9 to
4fef9ef
Compare
molebox
changed the title
molebox
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/deploysends agents to the wrong logs when a build fails and tells users the opposite of what happens to uncommitted files. This fixes both, plus a loose production-argument match.Why
ERRORdeployment, the command runsvercel logs <url>. That shows request and runtime logs, so a failed build returns nothing useful. Build output comes fromvercel inspect <url> --logs.verceluploads the local working tree minus the default ignore list and.vercelignore, so dirty and untracked files do ship. The warning should be the reverse.$ARGUMENTS"contains"prod, which also matches words like "product".Approach
commands/deploy.md.tmpl: usevercel inspect <url> --logsfor failed builds, flip the uncommitted-changes warning, and matchprod/productionas whole words.skills/deployments-cicd/SKILL.md(the "Inspect Deployments" section that/deployincludes): add the build-logs command and labelvercel logsas runtime logs. The--followline was dropped so the skill stays within the 12KBexplain vercel.jsonbudget the test enforces.commands/deploy.mdregenerated withbun run build:from-skills. The OpenCode test assertion was updated for the new gate wording.Validation
bun run typecheck && bun test: 1079 pass, 0 failbun run validate: passedbun run build:from-skills:check: 0 staleUpdate (@molebox)
Rebased onto
main. The headline change (switching the failure path tovercel inspect <url> --logsand usingvercel logs --deployment) already shipped in #332, so it was dropped. What's left:vercel deploycollects files using the built-in ignore list plus.vercelignore/.nowignoreonly..gitignorerules are never read and nothing runsgit ls-files. Evidence:getVercelIgnorein the shippedvercel@64.5.0, andpackages/client/src/utils/index.tsinvercel/vercel.prod/productionis now matched as a whole word. The test change only updates the rendered template text.vercel logsshows request and runtime logs, not build output."The optional
inspect --logs # build logsline in deployments-cicd was dropped. It pushed the skill over the 12,000-byte budget intests/cli-explain.test.ts, and/deployalready runs that command on failure.commands/deploy.mdis regenerated. All checks pass.