Repository navigation
Fix react-best-practices description and broken skill examples - #325
Merged
Merged
Conversation
…nd SSE example - marketplace: the destructive warning belongs on `vercel integration resource remove` (permanent delete), not `vercel integration remove` (uninstall; refuses while resources exist). Both still need explicit user approval. - react-best-practices: list all 8 upstream rule categories in the description and drop accessibility / "tsx linter" retrieval terms that contradict it. Replace the stale test that required the word "accessibility" with checks that the description's rule count matches the shipped rules and that retrieval does not advertise accessibility. - vercel-functions: the SSE GET handler reads the request URL so Next.js Cache Components does not prerender it at build time.
molebox
force-pushed
the
fix/skill-descriptions-and-examples
branch
from
October 19, 2026 11:38
20d8411 to
a805c2f
Compare
molebox
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small fixes to heavily used skills. Each one is a description that promises the wrong thing, an example that doesn't run, or a missing guard.
Why
hooks/hooks.jsonno longer registers. Agents now pick skills by description alone, so the description has to say what the skill really contains.data, sends raw chunks undertext/event-streamwith no SSE framing, and usessetTimeout, which this skill's ownvalidaterules flag.references/routing.md: the fallback example hardcodesanthropic/claude-opus-5andgoogle/gemini-3.1-pro-preview, although SKILL.md says not to put time-sensitive model IDs in reusable examples and to choose models from/v1/models.remove --yesappears in the CLI list with no warning, even though it deletes a provisioned resource and its data.Approach
react-best-practices/overlay.yaml: rewrite the description to match the rule categories and say what the skill does not cover. SKILL.md regenerated withbun run build:skills.vercel-functions: a self-containedGETSSE example withdata: ...\n\nframes andCache-Control: no-cache.ai-gateway: replace the hardcoded IDs with placeholders that point to/v1/models.marketplace: one line requiring explicit user approval beforeremove.Validation
bun run typecheck && bun test: 1079 pass, 0 failbun run validate: passedbun run build:skills:check: 0 staleUpdate (@molebox)
Rebased onto
mainand fixed the review findings against the shippedvercel@64.5.0CLI and upstreamvercel-labs/agent-skills.vercel integration resource remove(aliasesintegration-resource remove,ir rm) permanently deletes a resource, and refuses while projects are connected unless you pass--disconnect-all.vercel integration removeonly uninstalls, and fails while resources remain. Both still need user approval.check accessibility,accessibility,tsx linter). The 70-rule count matches the rule files, and the local copy is identical to upstream main.tests/external-skill-resolution.test.tsrequired the word "accessibility". It now checks that the rule count matches the files and that the retrieval metadata doesn't mention accessibility.GEThandler that reads no request data is prerendered at build time when Cache Components is on (Next 16.5 route-handler docs). The example now readsjobIdfromrequest.url, so it stays request-time.Checks:
build:*:check,validate, andbun run testall pass.