Refine Oasis shinecharges#1987
Merged
osse101 merged 5 commits intovg-json-data:masterfrom Mar 28, 2025
Merged
Conversation
osse101
reviewed
Mar 28, 2025
Contributor
osse101
left a comment
osse101
left a comment
There was a problem hiding this comment.
It would be possible to support unlocksDoors: missiles better now that shinesparkFrames can be added as a requirement there; I think the order of operations works. For LeaveWithSpark, the health cost would be minorly off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to Precious Room, this adds new nodes to represent having just gained a shinecharge while running into the room. It helps because there are many ways to gain the shinecharge and also many ways to use it. With this way of doing it, many strats are covered that were missed before. I also tightened shinecharge frames and shinespark frames.
Probably the most interesting addition is the way to do the stutter shinecharge using only 1 tile of runway. It requires being able to open the opposite door, and it needs a not-so-intuitive subpixel normalization in the other room, along with a double frame-perfect stutter. This one I think fits in Insane, with
canBeVeryPatient(could be improved with a more specific tech later). I created videos for these, showing all 3 ways that I know of to do the subpixel normalization.I was thinking about making the Insane one a notable, but it's a little awkward since the same technique is going to be applicable in other rooms (e.g. West Sand Hall Tunnel), making it seem better to handle it with tech.