Add wallJumpAvoid to strat and notable schema#1998
Merged
kjbranch merged 1 commit intovg-json-data:masterfrom Apr 3, 2025
Merged
Add wallJumpAvoid to strat and notable schema#1998kjbranch merged 1 commit intovg-json-data:masterfrom
kjbranch merged 1 commit intovg-json-data:masterfrom
Conversation
osse101
approved these changes
Apr 3, 2025
Contributor
osse101
left a comment
There was a problem hiding this comment.
-
Hopefully it is clear that a walljump being too difficult, whatever the tech level, still allows for easier alternative strats 😺
-
I like what this change lets us do. And if there is a grouping structure in the future we want to use, I don't think that would be difficult to switch to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a long-standing issue (#1001) about marking strats that are only useful in walljumpless contexts. This PR just adds a new boolean property
wallJumpAvoidto strats and notables, along with an example. Later PRs would go through and populate this throughout the logic.Based on the discussion in the issue, one alternative that was considered was implementing a more general
tagproperty. However, after thinking about this some more, it seems that a simple tag would not work well for the other examples mentioned in the issue. For example, to model a strat that softlocks you at an item location, we would want to model more information such as the specific item and/or tech that could get you out of the softlock. The existing "failures" schema is also relevant to modeling softlock risk, and we may want to refine/expand it someday, but a simple tag is again not going to be enough. And "patience" is already modeled through tech, so it seems unnecessary to model as a tag. A boolean property has the advantage of being a more structured format (compared to a bag of strings), making it more straightforward to consume.The plan is to use these properties in Map Rando to help reduce the clutter on the Generate page as well as the logic pages. The notable property
wallJumpAvoidwould apply to filtering notables on the Generate page; initially we may simply filter out the walljumpless notables from showing there, though eventually we could add some control to toggle them on or off. The strat propertywallJumpAvoidcan be applied to filter strats on logic pages for rooms and tech, and we already have a place to add a toggle for that.