Skip to content

Add wallJumpAvoid to strat and notable schema#1998

Merged
kjbranch merged 1 commit intovg-json-data:masterfrom
blkerby:wall-jump-avoid
Apr 3, 2025
Merged

Add wallJumpAvoid to strat and notable schema#1998
kjbranch merged 1 commit intovg-json-data:masterfrom
blkerby:wall-jump-avoid

Conversation

@blkerby
Copy link
Copy Markdown
Contributor

@blkerby blkerby commented Apr 2, 2025

This addresses a long-standing issue (#1001) about marking strats that are only useful in walljumpless contexts. This PR just adds a new boolean property wallJumpAvoid to strats and notables, along with an example. Later PRs would go through and populate this throughout the logic.

Based on the discussion in the issue, one alternative that was considered was implementing a more general tag property. However, after thinking about this some more, it seems that a simple tag would not work well for the other examples mentioned in the issue. For example, to model a strat that softlocks you at an item location, we would want to model more information such as the specific item and/or tech that could get you out of the softlock. The existing "failures" schema is also relevant to modeling softlock risk, and we may want to refine/expand it someday, but a simple tag is again not going to be enough. And "patience" is already modeled through tech, so it seems unnecessary to model as a tag. A boolean property has the advantage of being a more structured format (compared to a bag of strings), making it more straightforward to consume.

The plan is to use these properties in Map Rando to help reduce the clutter on the Generate page as well as the logic pages. The notable property wallJumpAvoid would apply to filtering notables on the Generate page; initially we may simply filter out the walljumpless notables from showing there, though eventually we could add some control to toggle them on or off. The strat property wallJumpAvoid can be applied to filter strats on logic pages for rooms and tech, and we already have a place to add a toggle for that.

Copy link
Copy Markdown
Contributor

@osse101 osse101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Hopefully it is clear that a walljump being too difficult, whatever the tech level, still allows for easier alternative strats 😺

  • I like what this change lets us do. And if there is a grouping structure in the future we want to use, I don't think that would be difficult to switch to.

@kjbranch kjbranch merged commit 184ae33 into vg-json-data:master Apr 3, 2025
1 check passed
@blkerby blkerby deleted the wall-jump-avoid branch February 15, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants