-
Notifications
You must be signed in to change notification settings - Fork 19
Removing and refining lower-difficulty notables #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -2463,20 +2463,32 @@ | |||||||
| { | ||||||||
| "id": 113, | ||||||||
| "link": [9, 5], | ||||||||
| "name": "Fast Climb with Space Jump", | ||||||||
| "name": "Fast Climb with Space Jump, No Rippers", | ||||||||
| "requires": [ | ||||||||
| {"notable": "Climb with Space Jump"}, | ||||||||
| {"notable": "Fast Climb with Space Jump"}, | ||||||||
| "SpaceJump", | ||||||||
| "canTrickyJump" | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| ], | ||||||||
| "wallJumpAvoid": true, | ||||||||
| "note": [ | ||||||||
| "Climb the top of Red Tower with just Space Jump.", | ||||||||
| "This can be done by dodging the Rippers and shooting the block as Samus is going upward, so she goes through the block as it breaks.", | ||||||||
| "HiJump or killing the Rippers can help but are not required.", | ||||||||
| "If the Rippers are killed, this can instead be done by shooting the block while falling right as it goes off screen,", | ||||||||
| "This can be done by shooting the block as Samus is going upward, so she goes through the block as it breaks.", | ||||||||
| "Alternatively, this can be done by shooting the block while falling right as it goes off screen,", | ||||||||
| "then using well-timed short space jumps to go up as rapidly as possible before the block respawns." | ||||||||
| ] | ||||||||
| }, | ||||||||
| { | ||||||||
| "link": [9, 5], | ||||||||
| "name": "Space Jump Climb Between the Rippers", | ||||||||
| "requires": [ | ||||||||
| "canPreciseSpaceJump", | ||||||||
| "canTrickyDodgeEnemies" | ||||||||
| ], | ||||||||
|
osse101 marked this conversation as resolved.
|
||||||||
| "note": [ | ||||||||
| "Climb the top of Red Tower with just Space Jump.", | ||||||||
| "This can be done by dodging the Rippers and shooting the block as Samus is going upward, so she goes through the block as it breaks." | ||||||||
| ] | ||||||||
| }, | ||||||||
| { | ||||||||
| "id": 114, | ||||||||
| "link": [9, 5], | ||||||||
|
|
@@ -2732,12 +2744,12 @@ | |||||||
| }, | ||||||||
| { | ||||||||
| "id": 9, | ||||||||
| "name": "Climb with Space Jump", | ||||||||
| "name": "Fast Climb with Space Jump", | ||||||||
| "wallJumpAvoid": true, | ||||||||
| "note": [ | ||||||||
| "Climb the top of Red Tower with just Space Jump.", | ||||||||
| "This can be done by dodging the Rippers and shooting the block as Samus is going upward, so she goes through the block as it breaks.", | ||||||||
| "HiJump or killing the Rippers can help but are not required.", | ||||||||
| "If the Rippers are killed, this can instead be done by shooting the block while falling right as it goes off screen,", | ||||||||
| "This can be done by shooting the block as Samus is going upward, so she goes through the block as it breaks.", | ||||||||
| "Alternatively, this can be done by shooting the block while falling right as it goes off screen,", | ||||||||
| "then using well-timed short space jumps to go up as rapidly as possible before the block respawns." | ||||||||
| ] | ||||||||
| } | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense to keep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is just adding the tech. Though, I was considering combining the 3 notables that raise the elevator eventually - it's not too important for now, since it will be split off as a walljumpless notable