Refine water shinecharge return in Oasis, Precious, and West Sand Hall Tunnel#2036
Merged
osse101 merged 1 commit intovg-json-data:masterfrom Apr 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are essentially copied from the bottom-left Aqueduct strats, with a few necessary adaptations:
In all of these, I removed the existing "Leave Shinecharged" strats. These started from a shinecharged junction node, and the location of the node is not defined precisely enough to use for this (i.e., since the exact location where you stop depends on the runway tiles used, which affects the frames remaining). So the new strats just go from the door node to itself, like the ones in Aqueduct. The shinecharged junction nodes are still used for the other existing strats, e.g., ones that perform a spark or chain temporary blue, since for those ones the exact location where you gain the shinecharge is unimportant.