Refine Crab Shaft shinecharges#2050
Merged
osse101 merged 1 commit intovg-json-data:masterfrom May 20, 2025
Merged
Conversation
Contributor
blkerby
commented
May 4, 2025
- Added a junction node 5 representing getting a shinecharge after running in from the left door.
- Added temporary blue chain strats from there to all 3 doors.
- Refined the shinespark frames and excessFrames for the strat that shinesparks up. The old value of 6 excess frames was unsound for getting onto the top platform.
osse101
reviewed
May 5, 2025
Comment on lines
+1919
to
+1921
| "canShinechargeMovementComplex", | ||
| {"shineChargeFrames": 120}, | ||
| {"shinespark": {"frames": 9}} |
Contributor
There was a problem hiding this comment.
- There isn't a simple way to shinespark back out the door.
- Are shineChargeFrames lenienced at this step? I don't want scaling to make a return shinespark impossible.
Contributor
Author
There was a problem hiding this comment.
Right, shinesparking back out the door requires turning around and shooting the door open first, which I was thinking justifies the "canShinechargeMovementComplex" requirement, and at that level it seemed reasonable to expect jumping toward the door a bit to save some energy. The lenience for shinecharge frames is 60 in Hard, 30 in Very Hard. So with this amount of frames, the spark would just barely be in Hard logic if "canShinechargeMovementComplex" were enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.