Refine Halfie Climb water shinecharges#2060
Merged
osse101 merged 3 commits intovg-json-data:masterfrom May 25, 2025
Merged
Conversation
osse101
reviewed
May 23, 2025
| { | ||
| "id": 81, | ||
| "link": [6, 4], | ||
| "name": "Leave With Temporary Blue (Hi-Jump, Gravity Jump, Spring Ball Jump)", |
Contributor
There was a problem hiding this comment.
This looks unsound to me. To be reasonable, you should store your shinespark a few tiles away from the wall, or have xray.
Contributor
Author
There was a problem hiding this comment.
Good catch, yeah this was intended to have a canXRayTurnaround requirement. Added that now. And added a FIXME for a shorter runway version without X-Ray.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.