Refine remaining water shinecharges#2084
Merged
osse101 merged 1 commit intovg-json-data:masterfrom Jun 7, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly copy-pasting strats from Aqueduct into similar rooms, for coming into a room with a water stutter, gaining a shinecharge, and then either sparking back out the same door or leaving with frames remaining. This completes my pass going through is refining all the water shinecharges. I know it is a bit of an obnoxious amount of duplication; hopefully in the future we could have a way to combine the strats for different runway lengths into a single strat. And the repeated long notes could fit better in a tech guide, once we have a place for that. A few things to note:
leaveWithTemporaryBluestrat with wrongunlocksDoorsrequirements in Aqueduct which I fix up here.