Tighten Big Pink right-side tunnel leaveShinecharged#2130
Merged
osse101 merged 1 commit intovg-json-data:masterfrom Jul 18, 2025
Merged
Tighten Big Pink right-side tunnel leaveShinecharged#2130osse101 merged 1 commit intovg-json-data:masterfrom
osse101 merged 1 commit intovg-json-data:masterfrom
Conversation
Contributor
|
Seems fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that even sparking out here wasn't in VH logic. It's currently expecting leaving shinecharged with 25 frames remaining, and VH would need 30. My best attempt leaves with 40. Proposed logic would be leaving with 35.
If we didn't want this in VH logic we could upgrade it to canShinechargeMovementTricky. I think it's probably ok though?