Add canLongXRayClimb tech#2135
Merged
blkerby merged 1 commit intovg-json-data:masterfrom Jul 18, 2025
Merged
Conversation
osse101
approved these changes
Jul 18, 2025
| "name": "Grapple Teleport X-Ray Climb (1 Screen)", | ||
| "entranceCondition": { | ||
| "comeInWithGrappleTeleport": { | ||
| "blockPositions": [[2, 18], [2, 19], [2, 28], [2, 29], [2, 34]] |
Contributor
There was a problem hiding this comment.
Was [2 34] missed on 5 and 6 before?
Contributor
Author
There was a problem hiding this comment.
Yeah, looks like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new tech
canLongXRayClimbdistinguishes climbs of length ~2 screens or more. For Map Rando this will help us to put only ~1 screen climbs into Very Hard logic. The idea is that when first learning to X-Ray climb it is nicer to only have to start out with relatively short ones.For some grapple teleport X-Ray climb strats, this required splitting off a second strat for the 2-screen variant. This is helpful anyway because now we can make the note more specific, telling the player how far to climb.
In Green Hill Zone, there was one case where the 2-screen grapple teleport X-ray climb variant was missing, so that is added here.
I also took the opportunity to clean up some of the older strat names, removing "Left-Side"/"Right-Side" since that information is redundant with the node that you're entering through.