Wall jump tech adjustments#2167
Merged
osse101 merged 5 commits intovg-json-data:masterfrom Jul 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a suggestion by @kjbranch this introduces a new tech
canTrickyWalljumpwhich replaces bothcanDelayedWalljumpandcanStaggeredWalljump. The idea is that individually these tech don't make a lot of sense:canConsecutiveWalljump.canDelayedWalljumpmade some sense in how it expressed an ability to control the horizontal position of the wall jump. But there's nothing that special about being able to control the horizontal position as opposed to other elements like the vertical position or the timing of the wall jump.In practice the ability to do wall jump strats seems determined less by specific tech knowledge and more by an overall skill level in wall jumping, and there are many factors that impact the difficulty of a given strat, including details of the geometry, any enemies/obstacles that get in the way, and the level of precision required in terms of timing and positioning; trying to boil it down to specific patterns like
canDelayedWalljumpandcanStaggeredWalljumpwas a bit of an awkward simplification that sometimes resulted in inappropriate difficulty placements. So the idea of the new techcanTrickyWalljumpis to give us a more direct way to describe a Hard-level wall jump difficulty, whilecanPreciseWalljumpremains a way to describe a Medium-level difficulty.To be easier to follow, the PR is split into 3 commits.
canPreciseWalljumpthat are redundant withcanTrickyWalljump, sincecanTrickyWalljumpis an extension ofcanPreciseWalljump(whereascanStaggeredWalljumpwasn't an extension ofcanPreciseWalljump).canPreciseWalljumptocanTrickyWalljump.