Indiana Jones G-Mode Restructure#2169
Merged
kjbranch merged 2 commits intovg-json-data:masterfrom Jul 26, 2025
Merged
Conversation
osse101
approved these changes
Jul 26, 2025
Contributor
osse101
left a comment
osse101
left a comment
There was a problem hiding this comment.
A GMode node looks useful but I also don't see it saving lines of code. There are the traversal nodes that come together to IBJ to the item then fall before branching again. And there are Remote Acquire And strats that would continue on to PB the blocks?
So I don't see groupings being large enough to be of much help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done to clean up the strats and make it more clear what to do. There is a lot going on still, so maybe it would be worth adding a junction node back, but it is not immediately clear how to best do that.
Also worth noting that the some of the old artificial morph strats required "canIBJ" instead of its morphless variant.