Skip to content

Remove R-mode Req from G-mode#2237

Merged
kjbranch merged 1 commit intovg-json-data:masterfrom
kjbranch:split-g-r-rename
Aug 19, 2025
Merged

Remove R-mode Req from G-mode#2237
kjbranch merged 1 commit intovg-json-data:masterfrom
kjbranch:split-g-r-rename

Conversation

@kjbranch
Copy link
Copy Markdown
Contributor

Of course, Github makes this simple change difficult to follow, so I'll describe the changes:

  • Removed R-mode as a requirement from G-mode (no longer an extension)
  • Split the tech description to fill a note and devNote for G-mode, upward setup, downward setup
  • Move upward setup and downward setup to be inside the extension of g-mode, it now requires g-mode instead of r-mode, and added a FIXME devNote to them

I have more I want to do, but the changes were starting to look too messy, so I'll finish the rest later.

Copy link
Copy Markdown
Contributor

@osse101 osse101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there was a separation of EnterRmode and UseRMode, EnterGMode would be an extension of EnterRMode still.
But then looking at up/down GMode, that is going to be just as hard whether it is RMode or GMode so we want a way to share them.
An upward RMode strat would be getting a blue suit in Croc farm.
A downward RMode strat I think could be clipping the crumble block in indiana jones.

@kjbranch
Copy link
Copy Markdown
Contributor Author

Good points. I'm going to merge this and then work on the second part that I was planning. I might undo some as well, we will see.

@kjbranch kjbranch merged commit afe2a4b into vg-json-data:master Aug 19, 2025
1 check passed
@kjbranch kjbranch deleted the split-g-r-rename branch August 19, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants