Skip to content

add CanSlopeSpark to logic #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjbranch merged 13 commits into from
Oct 8, 2025
Merged

add CanSlopeSpark to logic #2306

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c4df10d
add CanSlopeSpark to logic
nn357 Oct 6, 2025
5740ff4
added requirements for slopespark
nn357 Oct 7, 2025
5f3a84f
updated per the review notes on github
nn357 Oct 7, 2025
58210b4
changed order of logic
nn357 Oct 7, 2025
a93eca6
spelling error
nn357 Oct 7, 2025
26d9e36
Update region/brinstar/pink/Spore Spawn Farming Room.json
nn357 Oct 7, 2025
1637ebc
Update region/brinstar/pink/Spore Spawn Farming Room.json
nn357 Oct 7, 2025
d45249d
Update region/brinstar/pink/Spore Spawn Farming Room.json
nn357 Oct 7, 2025
d02bcd9
Update region/brinstar/pink/Spore Spawn Farming Room.json
nn357 Oct 7, 2025
751130d
Update tech.json
nn357 Oct 7, 2025
ed2c81d
Update region/brinstar/pink/Spore Spawn Farming Room.json
nn357 Oct 7, 2025
768eb85
Update region/brinstar/pink/Spore Spawn Farming Room.json
nn357 Oct 7, 2025
0e37dc0
Update region/brinstar/pink/Spore Spawn Farming Room.json
nn357 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions region/brinstar/pink/Spore Spawn Farming Room.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,53 @@
"leaveWithGModeSetup": {}
},
"flashSuitChecked": true
},
{
Comment thread
nn357 marked this conversation as resolved.
Outdated
"link": [2, 2],
"name": "Gain Flash Suit (Slopespark)",
"requires": [
"canSlopeSpark", "CanShineChargeMovement",
Copy link
Copy Markdown
Contributor

@blkerby blkerby Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canShineChargeMovement requirement should be dropped. The canSlopeSpark already includes an expectation that (normally) you would be moving with a shinecharge as part of the trick, and this is covered in the canShinechargeMovementComplex requirement in the techRequires of canCarryFlashSuit tech, a dependency of canSlopeSpark.

Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We keep 1 thing per line (the formatting will be able to fix itself eventually, so its not a big deal). Shiencharge movement complex is already a requirement on carrying a flash suit. (Which maybe we should add shinecharge movement complex to the new tech that sparks through the door as well)

Suggested change
"canSlopeSpark", "CanShineChargeMovement",
"canSlopeSpark",

{
"shineChargeFrames": 143
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to after the canshinecharge requirement (like, after the OR block)

},
{"or": [
{"canShineCharge": {"usedTiles": 20, "steepDownTiles": 2, "openEnd": 0}},
{"and": [
{"doorUnlockedAtNode": 2},
{"canShineCharge": {"usedTiles": 21, "steepDownTiles": 2, "openEnd": 0}}
]}
]},
{"enemyDamage": {"enemy": "Zeb", "type": "contact", "hits": 1}}
],
Comment thread
blkerby marked this conversation as resolved.
"note": [
"After shinecharging, lue a zeb and use it to slope spark on first slope right of the pipe"
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"After shinecharging, lue a zeb and use it to slope spark on first slope right of the pipe"
"After shinecharging, lure a Zeb and use it to slope spark on first slope right of the pipe."

],
"devNote": ["No leniency is given as this is a farm room and the zebs do little damage even suitless."]
},
{
Comment thread
nn357 marked this conversation as resolved.
Outdated
"link": [2, 2],
"name": "Gain Flash Suit (Slopespark) - Leave With Shinespark",
"requires": [ "canSlopeSpark", "canShinechargeMovement", "canComplexCarryFlashSuit",
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"requires": [ "canSlopeSpark", "canShinechargeMovement", "canComplexCarryFlashSuit",
"requires": [ "canSlopeSpark", "canComplexCarryFlashSuit",

{
"shineChargeFrames": 143
},
{"or": [
{"canShineCharge": {"usedTiles": 20, "steepDownTiles": 2, "openEnd": 0}},
{"and": [
{"doorUnlockedAtNode": 2},
{"canShineCharge": {"usedTiles": 21, "steepDownTiles": 2, "openEnd": 0}}
]}
]},
Comment thread
nn357 marked this conversation as resolved.
Outdated
{"enemyDamage": {"enemy": "Zeb", "type": "contact", "hits": 1}},
{"shinespark": {"frames": 12}}
],
"exitCondition": {
"leaveWithSpark": {}
},
"note": [
"After shinecharging, lue a zeb and use it to slope spark on first slope right of the pipe"
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"After shinecharging, lue a zeb and use it to slope spark on first slope right of the pipe"
"After shinecharging, lure a Zeb and use it to slope spark on first slope right of the pipe."

],
"devNote": ["No leniency is given as this is a farm room and the zebs do little damage even suitless."]
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"devNote": ["No leniency is given as this is a farm room and the zebs do little damage even suitless."]
"devNote": ["No leniency is given as this is a farm room and the Zebs do little damage, even suitless."]

}
],
"notables": [
Expand Down
13 changes: 13 additions & 0 deletions tech.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2290,6 +2290,19 @@
"Instead of crystal flashing, Samus will go down the elevator. If it was done properly, Samus' beam will be grey in color."
]
},
{
"name": "canSlopeSpark",
"techRequires": ["canHorizontalDamageBoost", "canCarryFlashSuit"],
"otherRequires": [
"SpeedBooster",
{"gainFlashSuit": {}}
],
"note": [
"The ability to take gain a flash suit without morphball by using an enemy damage boost to land on a slope and spark before knockback frames have expired.",
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The ability to take gain a flash suit without morphball by using an enemy damage boost to land on a slope and spark before knockback frames have expired.",
"The ability to take gain a flash suit without Morph by using an enemy damage boost to land on a slope and spark before knockback frames have expired.",

I thought this was frame perfect on the frame knockback expires?

Copy link
Copy Markdown
Contributor Author

@nn357 nn357 Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i sent you a video via dm.. it is not frame perfect.. it is before / up to when the knockback frame expires. it is why you can release opposite direction + jump from between 3 - 5 frames.. but maybe i should update it to include "on" the knockback frame.

"Gain a shinecharge, then while moving into an enemy near the top of a slope frame perfectly switch direction and hold the direction and jump for 3-5 frames",
"Jump can be pressed one frame before or the same frame as the direction switch. The opposite direction needs to be held for 3-5 frames, jump can be held longer"
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Gain a shinecharge, then while moving into an enemy near the top of a slope frame perfectly switch direction and hold the direction and jump for 3-5 frames",
"Jump can be pressed one frame before or the same frame as the direction switch. The opposite direction needs to be held for 3-5 frames, jump can be held longer"
"Gain a shinecharge, then while moving into an enemy near the top of a slope, frame perfectly switch direction and hold the direction and jump for 3-5 frames.",
"Jump can be pressed one frame before or the same frame as the direction switch. The opposite direction needs to be held for 3-5 frames, jump can be held longer."

]
},
{
"id": 208,
"name": "canComplexCarryFlashSuit",
Expand Down
Loading