Norfair East shinesparks: split speed and general cleanup#2817
Merged
osse101 merged 3 commits intovg-json-data:masterfrom Apr 8, 2026
Merged
Norfair East shinesparks: split speed and general cleanup#2817osse101 merged 3 commits intovg-json-data:masterfrom
osse101 merged 3 commits intovg-json-data:masterfrom
Conversation
osse101
reviewed
Apr 3, 2026
| }}, | ||
| "canMidairShinespark", | ||
| {"shinespark": {"frames": 1, "excessFrames": 1}} | ||
| {"or": [ |
Contributor
There was a problem hiding this comment.
Intentional to assume GMode means they know midair shinespark?
Contributor
Author
There was a problem hiding this comment.
I was here, but I dont think I assumed that in other places. I could add it back or do a pass to remove it on all g-mode to clean them up, or just do neither and remove them slowly if I notice them. Whichever you prefer.
Co-authored-by: Michael McKenzie <mikemck101@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.