Fix missing shinespark requirements on X-mode blue suit strats#2836
Merged
osse101 merged 1 commit intovg-json-data:masterfrom Apr 13, 2026
Merged
Fix missing shinespark requirements on X-mode blue suit strats#2836osse101 merged 1 commit intovg-json-data:masterfrom
osse101 merged 1 commit intovg-json-data:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported in the Discord (https://discord.com/channels/1053421401354285129/1053436236628496454/1492874425744232510).
The test is adjusted to catch cases like this from happening in the future.
I considered including
{"shinespark": {"frames": 0, "excessFrames": 0}in the helpers, but I think it's better to leave it explicit since for superjumps there may be a non-zero amount of frames required.