Skip to content

Require shinespark after double x-mode blue suit helpers #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osse101 merged 1 commit into from
May 3, 2026
Merged

Require shinespark after double x-mode blue suit helpers #2867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion region/brinstar/green/Etecoon Energy Tank Room.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,8 @@
}}
]}
]}
]}
]},
{"shinespark": {"frames": 0, "excessFrames": 0}}
],
"flashSuitChecked": true,
"blueSuitChecked": true,
Expand Down
3 changes: 2 additions & 1 deletion region/brinstar/kraid/Kraid Eye Door Room.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@
"link": [1, 1],
"name": "Gain Blue Suit (Double X-Mode)",
"requires": [
"h_thornDoubleXModeBlueSuitWithoutLenience"
"h_thornDoubleXModeBlueSuitWithoutLenience",
{"shinespark": {"frames": 0, "excessFrames": 0}}
],
"flashSuitChecked": true,
"blueSuitChecked": true
Expand Down
3 changes: 2 additions & 1 deletion region/maridia/inner-pink/East Cactus Alley.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1765,7 +1765,8 @@
"link": [4, 4],
"name": "Gain Blue Suit (Double X-Mode)",
"requires": [
"h_spikeDoubleXModeBlueSuit"
"h_spikeDoubleXModeBlueSuit",
{"shinespark": {"frames": 0, "excessFrames": 0}}
],
"flashSuitChecked": true,
"blueSuitChecked": true
Expand Down
2 changes: 1 addition & 1 deletion tests/asserts/keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ def process_req_speed_state(req, states, err_fn):
states = {"preshinespark"}
elif req in ["canDoubleXModeBlueSuit", "h_spikeDoubleXModeBlueSuit", "h_thornDoubleXModeBlueSuit",
"h_thornDoubleXModeBlueSuitWithoutLenience"]:
states = {"shinespark"}
states = {"preshinespark"}

elif isinstance(req, dict):
if "canShineCharge" in req:
Expand Down
Loading