Skip to content

feat: add optional ttlDays parameter #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 6 commits into from
Mar 24, 2026
Merged

feat: add optional ttlDays parameter #98

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca7042c
add optional ttlDays parameter
noahw3 Mar 10, 2026
c17b724
dynamically check certificate expiration
noahw3 Mar 11, 2026
9c68060
use single quotes
noahw3 Mar 11, 2026
9fbb9c4
use X509Certificate to parse cert instead of node-forge
noahw3 Mar 12, 2026
e351dac
use validToDate if present, otherwise more explicitly parse validTo f…
noahw3 Mar 12, 2026
8f556af
test: add test for date parsing
bluwy Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export default {
name: 'test',
/** custom trust domains */
domains: ['*.custom.com'],
/** optional, days before certificate expires */
ttlDays: 30,
/** custom certification directory */
certDir: '/Users/.../.devServer/cert',
}),
Expand Down
4 changes: 2 additions & 2 deletions src/certificate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ function toPositiveHex(hexString: string) {
export function createCertificate(
name: string = 'example.org',
domains?: string[],
ttlDays = 30,
): string {
const days = 30
const keySize = 2048

const appendDomains = domains
Expand Down Expand Up @@ -146,7 +146,7 @@ export function createCertificate(

cert.validity.notBefore = new Date()
cert.validity.notAfter = new Date()
cert.validity.notAfter.setDate(cert.validity.notBefore.getDate() + days)
cert.validity.notAfter.setDate(cert.validity.notBefore.getDate() + ttlDays)

cert.setSubject(attrs)
cert.setIssuer(attrs)
Expand Down
4 changes: 4 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ interface Options {
certDir: string
domains: string[]
name: string
ttlDays: number
}

function viteBasicSslPlugin(options?: Partial<Options>): Plugin {
Expand All @@ -18,6 +19,7 @@ function viteBasicSslPlugin(options?: Partial<Options>): Plugin {
options?.certDir ?? (config.cacheDir ?? defaultCacheDir) + '/basic-ssl',
options?.name,
options?.domains,
options?.ttlDays,
)
const https = () => ({ cert: certificate, key: certificate })
if (config.server.https === undefined || !!config.server.https) {
Expand All @@ -34,6 +36,7 @@ export async function getCertificate(
cacheDir: string,
name?: string,
domains?: string[],
ttlDays?: number,
) {
const cachePath = path.join(cacheDir, '_cert.pem')

Expand All @@ -52,6 +55,7 @@ export async function getCertificate(
const content = (await import('./certificate')).createCertificate(
name,
domains,
ttlDays,
)
fsp
.mkdir(cacheDir, { recursive: true })
Expand Down