feat: support setting proxy for reggie client#24
Merged
Conversation
CormickKneey
force-pushed
the
feat/set_proxy
branch
from
5c00588 to
c388c58
Compare
Contributor
Author
|
@vsoch Hi~ PTAL :) |
Owner
|
Apologies @CormickKneey I must have missed this email! Let's test, and then we will want to bump the version and add a note to the corresponding CHANGELOG.md. |
vsoch
requested changes
Jun 13, 2025
vsoch
left a comment
vsoch
left a comment
Owner
There was a problem hiding this comment.
The PR content looks good. For provenance (and the release) please bump the version in version.py, and add a corresponding note to CHANGELOG.md
Contributor
Author
Okay~ I will do this later. Thanks for your replying~ |
Signed-off-by: cormick <cormick1080@gmail.com>
CormickKneey
force-pushed
the
feat/set_proxy
branch
from
c388c58 to
ad89019
Compare
Contributor
Author
|
Done @vsoch |
vsoch
approved these changes
Jun 13, 2025
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds test cases for HTTP proxy functionality in the OCI reggie client with basic test.