Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes in
encoder.rs, the output bytes stay the same:get_block: when there is no subsampling (both strides are 1) it copies each row of 8 pixels from a slice, without the index math and bounds check per pixel.quantize_block: quantizes in natural order first and then reorders to zig-zag, so the quantize loop can be vectorized.The criterion
encodebench on an Apple M4 Pro, main vs this branch:With 4:4:4 sampling the gain is bigger, because every plane takes the new path: on x86-64 a 1200x630 RGBA image at quality 82 went from 6.29 ms to 5.57 ms. I checked the output is byte-identical there, with 4:4:4 and 4:2:0.
cargo test,cargo fmt --checkand clippy pass.