chore(#50): dead-code cleanup submodule bump + rebuild + decisions doc#46
Merged
Conversation
…isions Companion to webarkit/WebARKitLib#57. Bump the submodule to the cleanup commits (remove update() stub, im_gray(), commented _trackables/getPoseMatrix3) and rebuild build/ + dist/ (emscripten output is not byte-reproducible, so the artifacts change even for a behavior-neutral source edit). docs/audit-dead-code-issue50.md: add a "Decisions & status" section recording what was removed in #57 and what was deliberately KEPT (OCVT-derived symbols for ArtoolkitX parity, _trackVizActive scaffolding, and plausible WebARKit API / accessors / config constants), plus the one pending item (computePose cluster). Verified: static (pyrLevel 1) and webcam (pyrLevel 0) examples both track, 1000 matches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Re-point the submodule at the canonical webarkit/WebARKitLib dev tip after #57 (dead-code cleanup: update() stub, im_gray(), commented scaffolding) merged. Build artifacts unchanged (source identical to the pre-merge branch SHA). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added
enhancement
kalwalt
added a commit
that referenced
this pull request
Jun 21, 2026
Pick up the tracking-loss fix (webarkit/WebARKitLib#47, #46): the tracker now declares 'not found' when the marker leaves the frame instead of staying stuck on a stale pose. Rebuild build/ + dist/ and bump the submodule. Adds the design doc. Verified with the webcam Teblid example: removing the marker hides the AR content and shows 'Searching...'; no flicker while the marker is held. Refs #36, webarkit/WebARKitLib#46, webarkit/WebARKitLib#47 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added a commit
that referenced
this pull request
Jun 21, 2026
…xample Bump WebARKitLib to the part-A downsampling change (webarkit/WebARKitLib#52) and rebuild build/ + dist/. Feature detection now runs on a pyrDown'd copy of the live frame; matched keypoints are rescaled to full-frame coords. - examples: point the Teblid static-image example at a marker-fills-frame 1920x1440 demo image (pinball-demo-big.jpg) so HD downsampling is exercised (pyrLevel 1, scale 2.0) and the marker still acquires. The old pinball-demo.jpg (small marker in a large frame) falls below the detector threshold once downsampled. - docs: add docs/design-detection-downsampling.md (understanding, ArtoolkitX reference, decision log, the four edits, testing, risks, non-goals). Verified: Marker tracked, 1000 matches, content centered (#38) and right-handed (#42/#46), no #43-style doubling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to webarkit/WebARKitLib#57 (the #50 dead-code cleanup).
What
update()dangling decl,im_gray(), commented_trackables[…]/getPoseMatrix3).build/+dist/. The emscripten build is not byte-reproducible, so the artifacts change even though the source edit is behavior-neutral.docs/audit-dead-code-issue50.md: new "Decisions & status" section recording the final dispositions — what #57 removed, and what we deliberately kept (OCVT-derived symbols for ArtoolkitX parity,_trackVizActivedebug scaffolding, and plausible WebARKit API/accessors/config constants), plus the one pending item.Testing
Rebuilt and verified both examples: static (1920×1440, pyrLevel 1) and webcam (640×480, pyrLevel 0) track — 1000 matches, lost→found re-acquisition intact.
Note
Points at the
cleanup/dead-code-50branch SHA for now; I'll re-bump to the mergeddevtip after #57 lands (the usual pattern).🤖 Generated with Claude Code