Skip to content

Fix broken image URLs in DOM exercise finished HTML#268

Open
Vedant43hh wants to merge 1 commit into
wesbos:masterfrom
Vedant43hh:fix-broken-images-dom-exercise
Open

Fix broken image URLs in DOM exercise finished HTML#268
Vedant43hh wants to merge 1 commit into
wesbos:masterfrom
Vedant43hh:fix-broken-images-dom-exercise

Conversation

@Vedant43hh

Copy link
Copy Markdown

Description

This PR fixes broken images in the finished version of the DOM exercise.

The image URLs were using outdated picsum.photos endpoints that no longer load correctly in some environments. Updated the image sources to use working Picsum seed-based URLs so the exercise displays images as expected.

Changes Made

  • Updated image URLs in:
    • exercises/20 - The DOM/index-FINISHED.html
  • Replaced deprecated Picsum URLs with valid seed-based URLs.
  • Restored image rendering in the finished exercise.

Testing

  • Opened index-FINISHED.html
  • Verified that all images load correctly
  • Confirmed that no other functionality was affected

Related Issue

Fixes #206

@wesbos

wesbos commented Jun 24, 2026

Copy link
Copy Markdown
Owner

@Asjas can you mirror this to the starter files as well?

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates image src URLs in the finished HTML for the DOM exercise to restore broken image rendering by switching to seed-based picsum.photos URLs.

Changes:

  • Updated several <img> src attributes in exercises/20 - The DOM/index-FINISHED.html to use seed-based Picsum URLs.
  • Adjusted the main hero image URL to an explicit 500/500 endpoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +18 to +20
<img class="custom" data-last="bos" data-name="wes" src="https://picsum.photos/seed/picsum/200/200" />
<img data-name="kait" src="https://picsum.photos/200" />
<img data-name="lux" src="https://picsum.photos/200" />
<img data-name="lux" src="https://picsum.photos/seed/picsum/200/200" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Images in The DOM exercise's finished HTML

4 participants