Repository navigation
Play redesign follow-ups: remove dead assets + per-question /play metadata - #54
Merged
Merged
Conversation
Card images are now generated in code (src/server/card-image.ts -> /og/{lang}/{id}.png),
so the 924 committed LFS PNGs under public/images/ are unreferenced; remove them and
the now-empty .gitattributes (it only tracked those files). GameControls was only used
by the removed per-question page (now a 301 to /play); delete it too.
Head.astro now accepts id/language as props (falling back to route params), so the
SSR /play page can supply the per-question metadata the old static question pages got
from params. /play?lang=&q= -> title 'WhoCards | Question #N', og:locale=lang,
og:image=/og/{lang}/{id}.png; no/invalid q falls back to the generic title + social.png.
✅ Deploy Preview for whocards-calmly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups after the play redesign (#41–#44, #46), as separate commits.
1. Remove dead assets — Closes #50
public/images/(~102 MB). Cards are now generated in code (src/server/card-image.ts→/og/{lang}/{id}.png), so these are unreferenced — confirmed nosrcreferences..gitattributes(it only tracked those PNGs).src/components/GameControls/— only the removed per-question page used it (now a 301 →/play); confirmed zero importers.2. Per-question metadata on SSR
/playHead.astroacceptsid/languageprops (falling back to route params);Layout.astroforwards them./play?lang=&q=now emits per-question<title>(WhoCards | Question #N),og:locale, andog:image(/og/{lang}/{id}.png) for crawlers — previously onlyog:imagewas per-question. No/invalidq→ generic title +social.png.og:localeis now populated on other pages too (it was empty before) — a small, positive SEO change. Broader audit tracked in Research: site-wide SEO optimizations & polish #52.pnpm buildpasses.