Repository navigation
Conversation
Flips PUBLIC_APP_ANDROID_LAUNCHED default to true, makes the /app meta description launch-aware, redirects the retired tester funnel to /app, and updates the SSR e2e suite and docs for the launched state.
✅ Deploy Preview for whocards-calmly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for whocards-app canceled.
|
| [[redirects]] | ||
| from = "/android-testers" | ||
| to = "/app" | ||
| status = 302 | ||
| force = true |
There was a problem hiding this comment.
🟠 High website/netlify.toml:52
When PUBLIC_APP_ANDROID_LAUNCHED=false, the “Become a tester” CTA links to /android-testers, but this forced redirect sends visitors to /app instead of the tester instructions. Make this redirect conditional on launch state or change the false-state CTA to a reachable destination.
-[[redirects]]
- from = "/android-testers"
- to = "/app"
- status = 302
- force = true🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/website/netlify.toml around lines 52-56:
When `PUBLIC_APP_ANDROID_LAUNCHED=false`, the “Become a tester” CTA links to `/android-testers`, but this forced redirect sends visitors to `/app` instead of the tester instructions. Make this redirect conditional on launch state or change the false-state CTA to a reachable destination.
The redirect in netlify.toml keeps old links landing on /app.
Don't merge until the Play listing is public. Merge = website deploy = Play badge goes live on /app.
/app: Android tile becomes a real Google Play download; "in testing" copy gone/android-testers*→ 302 to/app; birthday tester page deletedRollback: set
PUBLIC_APP_ANDROID_LAUNCHED=falseon Netlify and redeploy.Part of #98 📋 · Linear WHO-8
For AI
Changes
packages/env/src/website.ts:PUBLIC_APP_ANDROID_LAUNCHEDdefaultfalse→true. The flag stays as a kill switch, so/app's tester-tile branch still works if it gets set to false.apps/website/src/pages/app.astro: meta description was hardcoded "Android is in testing". It now depends on the flag.apps/website/netlify.toml: 302 for/android-testersand/android-testers-birthday-present→/app.apps/website/tests/e2e-ssr/app.spec.ts: asserts the launched state (both store links, noandroid-testtile, Android UA leads with Google Play).android-testers-birthday-present.astro+ its OG image, indexation and smoke-test entries. The netlify redirect covers old links..env.example,docs/DESIGN.md,constants/app*.tsandplaywright.ssr.config.tsupdated.Verified locally
astro checkand vitest (387) all green./appdescription reads "Download WhoCards on iOS and Android…".https://play.google.com/store/apps/details?id=com.whocards.mobilereturns 404 until the listing goes public. Check it resolves before merging.Deliberately left out
constants/android-testers, tester env vars, tester emails). The completion thank-you email still has to go out, so that cleanup gets its own PR afterwards.eas.jsonsubmit track staysalphabecause the pipeline is beta-first. Future releases still get promoted by hand.Note
Launch Android publicly: default
PUBLIC_APP_ANDROID_LAUNCHEDto true and route legacy tester paths to /appPUBLIC_APP_ANDROID_LAUNCHEDfrom false to true increateWebsiteEnv,.env.example, and related comments, so deployments show Google Play content without extra config/android-testersand/android-testers-birthday-presentto/appin netlify.toml/apppage description metadata conditional on the flag in app.astro, and updates the SSR e2e suite to require Google Play content with no tester tile/android-testersper updated guidance in DESIGN.md📊 Macroscope summarized a169e90. 8 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted
🗂️ Filtered Issues