Skip to content

ci: the quality gate runs the review-diff tests - #408

Merged
acharlop merged 3 commits into
mainfrom
ci/274-run-review-diff-tests
Nov 6, 2026
Merged

acharlop merged 3 commits into
mainfrom
ci/274-run-review-diff-tests

Conversation

@acharlop

@acharlop acharlop commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

CI now runs scripts/ci/review-diff.test.mjs. It ran nowhere before: pnpm check only reaches workspace packages. One line in ci.yml.

This is the workflow half of #380 🔀 that was held for an SSH push. Part of #274 📋, which stays open: its done-when needs ~20 logged PRs and a keep/drop decision.

For AI
  • Source: ~/.factory/whocards/runs/2026-11-04/274-ci-workflow.patch, commit 1/2 (e462af0), applied as written.
  • Commit 2/2 of that patch (pin ci.yml actions) is dropped: #407 🔀 pins all three workflows for #405 📋, and the patch's caching-for-turbo pin (v2.5.1) is older than main (v2.5.2). This PR adds no uses:, so there's nothing new to pin. The two PRs touch separate hunks of ci.yml and merge in either order.
  • Local: node --test scripts/ci/review-diff.test.mjs 11/11 pass; pnpm format clean.
  • Still open on Measure Greptile against the code-review skill: per-PR diff of findings #274, not part of this PR: /code-review posting a <!-- claude-review --> marker comment (personal skills), the baseline re-run over the 13 June PRs, ~20 logged rows, then Avi's keep/drop call.

Note

Run review-diff.test.mjs in the CI quality gate

Adds a Node test command for scripts/ci/review-diff.test.mjs to the WhoCards skill checks step in the quality gate job of ci.yml.

Macroscope summarized 4824705.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Adds scripts/ci/review-diff.test.mjs to the required quality gate.

  • The quality gate now runs the review-diff tests.

Reviews (1) · Last reviewed commit: "ci: the quality gate runs the review-dif..." · Reviewed by Greptile

pnpm check only reaches workspace packages, so the root script's tests
ran nowhere. The skill-checks step already runs root node --test files.

Part of #274
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 6bf7165 and 4824705.

Files selected for processing: 1

  • .github/workflows/ci.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@netlify

netlify Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for whocards-calmly canceled.

Name Link
🔨 Latest commit 4824705
🔍 Latest deploy log https://app.netlify.com/projects/whocards-calmly/deploys/6aee5e47ecf0861fc2a41134

@netlify

netlify Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for whocards-app canceled.

Name Link
🔨 Latest commit 4824705
🔍 Latest deploy log https://app.netlify.com/projects/whocards-app/deploys/6aee5e47a102e05e781974e6

@macroscopeapp

macroscopeapp Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Approved at a069da7

Macroscope's review found this PR approvable — Adds the existing review-diff tests to the CI quality gate. The tests operate on in-memory fixtures without invoking GitHub APIs or writing files, keeping the impact confined to CI.

No code changes detected at 4824705. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@acharlop
acharlop enabled auto-merge (squash) November 6, 2026 22:35
@acharlop
acharlop merged commit 841cf61 into main Nov 6, 2026
14 checks passed
@acharlop
acharlop deleted the ci/274-run-review-diff-tests branch November 6, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant