Repository navigation
ci: the quality gate runs the review-diff tests - #408
Conversation
pnpm check only reaches workspace packages, so the root script's tests ran nowhere. The skill-checks step already runs root node --test files. Part of #274
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
✅ Deploy Preview for whocards-calmly canceled.
|
✅ Deploy Preview for whocards-app canceled.
|
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds the existing review-diff tests to the CI quality gate. The tests operate on in-memory fixtures without invoking GitHub APIs or writing files, keeping the impact confined to CI. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
CI now runs
scripts/ci/review-diff.test.mjs. It ran nowhere before:pnpm checkonly reaches workspace packages. One line inci.yml.This is the workflow half of #380 🔀 that was held for an SSH push. Part of #274 📋, which stays open: its done-when needs ~20 logged PRs and a keep/drop decision.
For AI
~/.factory/whocards/runs/2026-11-04/274-ci-workflow.patch, commit 1/2 (e462af0), applied as written.ci.ymlactions) is dropped: #407 🔀 pins all three workflows for #405 📋, and the patch's caching-for-turbo pin (v2.5.1) is older than main (v2.5.2). This PR adds nouses:, so there's nothing new to pin. The two PRs touch separate hunks ofci.ymland merge in either order.node --test scripts/ci/review-diff.test.mjs11/11 pass;pnpm formatclean./code-reviewposting a<!-- claude-review -->marker comment (personal skills), the baseline re-run over the 13 June PRs, ~20 logged rows, then Avi's keep/drop call.Note
Run
review-diff.test.mjsin the CI quality gateAdds a Node test command for
scripts/ci/review-diff.test.mjsto the WhoCards skill checks step in the quality gate job of ci.yml.Macroscope summarized 4824705.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Adds
scripts/ci/review-diff.test.mjsto the required quality gate.Reviews (1) · Last reviewed commit: "ci: the quality gate runs the review-dif..." · Reviewed by Greptile