Preserve viewport edit draft when queued request executes#666
Open
liaowang11 wants to merge 1 commit into
Open
Preserve viewport edit draft when queued request executes#666liaowang11 wants to merge 1 commit into
liaowang11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a command is sent (e.g. a queued request executing) while the user is composing in the viewport edit buffer, the draft is now saved to the compose snapshot instead of being wiped by the switch to view mode. The draft is restored on the next return to edit mode.
Why
agent-shell--send-commandswitches the viewport to view mode and re-initializes the buffer. If a queued request runs while the user is mid-composition in the viewport edit buffer, their in-progress draft was lost. Reusing the existingagent-shell-viewport--compose-snapshotmechanism preserves it.Checklist
M-x checkdocandM-x byte-compile-file.