Skip to content

Startup log URL redaction: remaining edge cases (follow-up to #823) #826

Closed

Description

@zereight

Follow-up to #823 (redact credentials in startup URL logs).

#823 redacts userinfo and secret query params in the GitLab API URL lines logged at startup. A few rare input shapes are still not redacted and were left out of scope there:

  1. URL in the middle of free text – a URL embedded inside a longer sentence is not detected/redacted by the text matcher.
  2. Single-slash scheme – https:/user:pass@host (one slash) is not treated as having userinfo.
  3. Secrets in the URL fragment – e.g. https://host/api/v4#private_token=...; only the query string is scrubbed, not the fragment.
  4. Commas inside the password – when the URL list is split on commas, a password containing , gets cut and the tail can leak.

All of these require unusual configuration values, so impact is low, but the redaction helper should cover them for defense in depth.

Suggested fix: extend the shared redaction helper (introduced in #811/#823) to handle these cases, with unit tests for each.

Activity

  1. added 2 commits that reference this issue on Oct 19, 2026
  2. zereight commented on Oct 19, 2026

    @zereight
    OwnerAuthor

    Fixed by #841, released in v2.3.4. Stricter validation for ambiguous URL lists is tracked in #876.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions