Repository navigation
ci: raise docker-publish timeout to 40 minutes - #836
Merged
Merged
Conversation
v2.2.3 hit the 20-minute job limit and had to be retried; recent successful multi-arch builds already take ~18 minutes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to The 40-minute cap addresses the reported timeout cancellation while keeping the job bounded. No merge-blocking risk is evident from this change. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: increasing the Docker publish timeout to 40 minutes. |
| Description check | |
The description accurately explains the timeout change, the triggering build failures, the expected effect, and the scope of follow-up work. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dockerjobtimeout-minutesfrom 20 to 40 in.github/workflows/docker-publish.yml.docker-publishrun cancelled at the 20-minute limit; retry succeeded (~18 min job). v2.2.2 was also ~18 min.Why builds are slow (follow-up, not in this PR)
linux/amd64,linux/arm64onubuntu-latestmeans arm64 goes through QEMU, and there is no Buildx GHA cache (cache-from/cache-to). Typical recent successes sit near 18–19 minutes, so the old 20-minute cap was too tight.Possible later improvements (out of scope here):
Test plan
docker-publishshould finish without a timeout cancel when the build takes ~18–25 minutes