Feature: Allow zotero:// as valid protocol#4
Open
julkusapiens wants to merge 23 commits intozotero:masterfrom
Open
Feature: Allow zotero:// as valid protocol#4julkusapiens wants to merge 23 commits intozotero:masterfrom
julkusapiens wants to merge 23 commits intozotero:masterfrom
Conversation
(cherry picked from commit f2ad361)
(cherry picked from commit a15335f)
(cherry picked from commit c0c8aac)
(cherry picked from commit 1733922)
(cherry picked from commit c76d802)
(cherry picked from commit e268317)
(cherry picked from commit 5dcfa53)
(cherry picked from commit 946f8be)
(cherry picked from commit 03a4a3f)
(cherry picked from commit 444f950)
(cherry picked from commit ffc7226)
(cherry picked from commit 2a2c8a1)
(cherry picked from commit beb5a70)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
zotero://protocol to be treated as valid in the PDF viewer.Without this change, links using the Zotero protocol are not clickable,
even though Zotero registers and uses this scheme intentionally.
Firefox's pdf.js tries to prevent XSS by limiting the allowed protocols.
Zotero accepting its own protocol is only logical.
This is a minimal one-line change and does not affect existing
protocol handling.