Annual Reviews: Update target URL patterns and improve BibTeX handling#3588
Open
mjthoraval wants to merge 5 commits intozotero:masterfrom
Open
Annual Reviews: Update target URL patterns and improve BibTeX handling#3588mjthoraval wants to merge 5 commits intozotero:masterfrom
mjthoraval wants to merge 5 commits intozotero:masterfrom
Conversation
mjthoraval
changed the title
AbeJellinek
reviewed
Mar 6, 2026
| var title = ZU.trimInternal(link.textContent); | ||
|
|
||
| if (!title || title.length < 3) continue; | ||
| if (title.toLowerCase().includes('more') || title.toLowerCase().includes('less')) continue; |
Member
There was a problem hiding this comment.
I personally think we shouldn't write off good scientific research just because it has the word "more" or "less" in its title :)
Is this intended to handle a specific case?
Author
There was a problem hiding this comment.
Thanks for the review.
I have tested again on the test URLs, and I cannot find any problem without this line.
So it should probably be removed indeed.
It is probably some leftovers from the iterations I did where I still had some wrong items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://forums.zotero.org/discussion/115080/cannot-import-pdf-file-from-annual-reviews-journal