Repository navigation
Device: download and cache ArduPilot device IDs - #3859
Draft
Sharanie0612 wants to merge 2 commits into
Draft
Sharanie0612 wants to merge 2 commits into
Sharanie0612 wants to merge 2 commits into
Conversation
Collaborator
|
it should be downloaded and cached, not embedded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardware IDs display numeric values for IMU types absent from the local enums. Read names from ArduPilot's generated devid.json so new catalog entries can be recognized without adding C# enum members.
Related to #3778. Following the feedback on this PR, the catalog is downloaded and cached locally; it is no longer embedded or shipped with the application.
SENSOR_ID#handling.Validation: Windows Release build and MSI packaging succeeded. Administrative MSI extraction and hashes of the packaged EXE/DLL files were verified on the Windows runner. The downloaded MSI SHA-256 was also checked locally. Physical flight-controller validation is still pending.
Kept as a draft for discussion of the download/cache approach.