Repository navigation
test(e2e): move the pointer off the Deepness multiselect button - #8458
Merged
TheWitness merged 1 commit intoOct 23, 2026
Merged
TheWitness merged 1 commit into
TheWitness merged 1 commit into
Conversation
Deepness sets a zero body margin, so the unhovered #ms-button sits at the viewport origin and headless Chromium on Linux intermittently applies :hover to it. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
requested review from
cigamit
and removed request for
a team
October 22, 2026 23:52
|
somethingwithproof
added
github_actions
This was referenced Oct 23, 2026
bmfmancini
approved these changes
Oct 23, 2026
TheWitness
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the Deepness theme test measure the button’s normal colour consistently. It moves the mouse pointer away before reading the computed style, so an accidental hover does not change the result. This removes a source of intermittent browser-test failures while retaining the existing colour assertions.
Implementation details
The Deepness multiselect test from #8443 fails intermittently in the chromium job:
#ms-buttonreadsrgb(22, 28, 37)(the hover colour) instead ofrgb(17, 22, 29).Deepness sets
body { margin: 0 }, so the button sits at the viewport origin, and headless Chromium on Linux sometimes leaves the pointer there and matches.ui-multiselect.ui-state-default:hover. Moving the pointer to (5, 5) before reading styles reproduces the exact CI diff locally.The test now moves the pointer to an empty part of the page before reading computed styles. The assertions are unchanged and the CSS is correct.
Verified: with a forced move to (5, 5) followed by the fix, 10/10 runs pass. The workflow's two specs pass with
--repeat-each=5(510 passed, macOS Chromium, Playwright 1.64.0, Node 22).Revision and checks
Verified 2026-10-23 06:05 UTC at
fd0af43a8; targetdevelop, 1 changed file.GitHub reports 37 passed, 3 skipped, 1 neutral, with no failed or pending checks. Skipped and neutral checks are not counted as passed. Earlier local measurements above retain their stated environments and revisions. Independent approval is still required before merge.